From fdd5192a9e2a0815614b092a84b86d39649a76be Mon Sep 17 00:00:00 2001 From: Olyutorskii Date: Wed, 12 Jun 2019 18:35:55 +0900 Subject: [PATCH] use String constants. --- src/main/java/jp/sfjp/mikutoga/xml/DatatypeIo.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/main/java/jp/sfjp/mikutoga/xml/DatatypeIo.java b/src/main/java/jp/sfjp/mikutoga/xml/DatatypeIo.java index 000c43e..1b45fa8 100644 --- a/src/main/java/jp/sfjp/mikutoga/xml/DatatypeIo.java +++ b/src/main/java/jp/sfjp/mikutoga/xml/DatatypeIo.java @@ -22,6 +22,11 @@ package jp.sfjp.mikutoga.xml; */ public final class DatatypeIo { + private static final String XSD_POS_INF = "INF"; + private static final String XSD_NEG_INF = "-INF"; + private static final String JAVA_INF = "Infinity"; + + /** * Hidden constructor. */ @@ -53,9 +58,9 @@ public final class DatatypeIo { String result; if(fVal == Float.POSITIVE_INFINITY){ - result = "INF"; + result = XSD_POS_INF; }else if(fVal == Float.NEGATIVE_INFINITY){ - result = "-INF"; + result = XSD_NEG_INF; }else{ result = String.valueOf(fVal); } @@ -202,11 +207,11 @@ public final class DatatypeIo { String trimmed = xsdTrim(xsdVal).toString(); float result; - if("INF".equals(trimmed)){ + if(XSD_POS_INF.equals(trimmed)){ result = Float.POSITIVE_INFINITY; - }else if("-INF".equals(trimmed)){ + }else if(XSD_NEG_INF.equals(trimmed)){ result = Float.NEGATIVE_INFINITY; - }else if(trimmed.endsWith("Infinity")){ + }else if(trimmed.endsWith(JAVA_INF)){ throw new NumberFormatException(trimmed); }else if(trimmed.contains("x") || trimmed.contains("X")){ // HexFloatingPointLiteral -- 2.11.0