passed. original picture model test

[pettanr/pettanr.git] / app / models / original_picture.rb

diff --git a/app/models/original_picture.rb b/app/models/original_picture.rb
index d178db2..e323eb6 100644 (file)
--- a/app/models/original_picture.rb
+++ b/app/models/original_picture.rb
@@ -3,6 +3,13 @@ class OriginalPicture < ActiveRecord::Base
   belongs_to :license
   has_one :resource_picture
   
+  validates :ext, :presence => true, :length => {:maximum => 4}, :inclusion => {:in => ['png', 'jpeg', 'gif']}\r
+  validates :width, :presence => true, :numericality => true, :natural_number => true
+  validates :height, :presence => true, :numericality => true, :natural_number => true
+  validates :filesize, :presence => true, :numericality => {:greater_than => 0, :less_than_or_equal_to => 2000000}, :natural_number => true
+  validates :artist_id, :presence => true, :numericality => true, :existence => true
+  validates :license_id, :presence => true, :numericality => true, :existence => true
+  
   before_destroy :destroy_with_file
   
   def validate
@@ -87,14 +94,20 @@ class OriginalPicture < ActiveRecord::Base
     '/original_pictures/' + filename
   end
   
-  def store(picture_data, art, lid = nil)
-    res = false
+  def data_to_mgk picture_data
     begin
       mgk = Magick::Image.from_blob(picture_data).shift
     rescue 
       self.errors.add :base, 'magick failed'
       return false
     end
+    mgk
+  end
+  
+  def store(picture_data, art, lid = nil)
+    mgk = data_to_mgk picture_data
+    return false unless mgk
+    res = false
     self.attributes = {:ext => mgk.format.downcase, :width => mgk.columns, :height => mgk.rows, 
       :filesize => mgk.filesize, :artist_id => art.id, 
       :license_id => lid.blank? ? art.default_license_id : lid.to_i
@@ -104,10 +117,12 @@ class OriginalPicture < ActiveRecord::Base
         if res = PictureIO.original_picture_io.put(picture_data, self.filename)
           rp = ResourcePicture.update_picture(self)
           unless rp.store(mgk)
+            res = false
             PictureIO.original_picture_io.delete(self.filename)
             self.errors.add :base, 'resource picture copying error'
             raise ActiveRecord::Rollback
           end
+          res = true
         else
           self.errors.add :base, 'original picture io does not work'
           raise ActiveRecord::Rollback