From: henoheno <henoheno>
Date: Mon, 1 Aug 2005 15:38:26 +0000 (+0900)
Subject: BugTrack2/98: fopen(w) [file size zero] before flock(LOCK_EX) is unacceptable
X-Git-Tag: r1_5_0_rc1~236
X-Git-Url: http://git.osdn.net/view?p=pukiwiki%2Fpukiwiki.git;a=commitdiff_plain;h=eeb42d93b0f50828162b525fcaf4ad952434c60e

BugTrack2/98: fopen(w) [file size zero] before flock(LOCK_EX) is unacceptable
---

diff --git a/lib/file.php b/lib/file.php
index 310658f..ecd3c50 100644
--- a/lib/file.php
+++ b/lib/file.php
@@ -1,6 +1,6 @@
 <?php
 // PukiWiki - Yet another WikiWikiWeb clone.
-// $Id: file.php,v 1.37 2005/08/01 15:07:36 henoheno Exp $
+// $Id: file.php,v 1.38 2005/08/01 15:38:26 henoheno Exp $
 // Copyright (C)
 //   2002-2005 PukiWiki Developers Team
 //   2001-2002 Originally written by yu-ji
@@ -174,7 +174,7 @@ function file_write($dir, $page, $str, $notimestamp = FALSE)
 		if ($notimestamp && file_exists($file))
 			$timestamp = filemtime($file) - LOCALZONE;
 
-		$fp = fopen($file, 'r+') or die('fopen() failed: ' .
+		$fp = fopen($file, 'a') or die('fopen() failed: ' .
 			htmlspecialchars(basename($dir) . '/' . encode($page) . '.txt') .	
 			'<br />' . "\n" .
 			'Maybe permission is not writable or filename is too long');