OSDN Git Service

usb-storage: tag usb_msd_csw as packed struct
authorGerd Hoffmann <kraxel@redhat.com>
Mon, 6 Sep 2021 04:55:23 +0000 (06:55 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 2 Nov 2021 16:24:18 +0000 (17:24 +0100)
commit58d7d4c7869cb3addb0714aa7b6bd88f2b6b7edf
tree567c1b9036e6d7b08a7bdd9a79ec2debfbc54b18
parent7c8d295b274f18f582b931c59dba0cba94f6ca7a
usb-storage: tag usb_msd_csw as packed struct

Without this the struct has the wrong size: sizeof() evaluates
to 16 instead of 13.  In most cases the bug is hidden by the
fact that guests submits a buffer which is exactly 13 bytes
long, so the padding added by the compiler is simply ignored.

But sometimes guests submit a larger buffer and expect a short
transfer, which does not work properly with the wrong struct
size.

Cc: vintagepc404@protonmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Fixes: a917d384ac0 ("SCSI TCQ support.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210906045523.1259629-1-kraxel@redhat.com>
include/hw/usb/msd.h