OSDN Git Service

hw/misc/mps2-scc: Free MPS2SCC::oscclk[] array on finalize()
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 21 Nov 2023 17:40:48 +0000 (18:40 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 27 Nov 2023 15:27:42 +0000 (15:27 +0000)
commit896dd6ff7b9f2575f1a908a07f26a70b58d8b675
tree4aeee68227a881400f62e48d8df3b543ef63b49f
parentc9a4aa06dfce0fde1e279e1ea0c1945582ec0d16
hw/misc/mps2-scc: Free MPS2SCC::oscclk[] array on finalize()

Commit 0be6bfac62 ("qdev: Implement variable length array properties")
added the DEFINE_PROP_ARRAY() macro with the following comment:

  * It is the responsibility of the device deinit code to free the
  * @_arrayfield memory.

Commit 4fb013afcc added:

  DEFINE_PROP_ARRAY("oscclk", MPS2SCC, num_oscclk, oscclk_reset,
                    qdev_prop_uint32, uint32_t),

but forgot to free the 'oscclk_reset' array. Do it in the
instance_finalize() handler.

Cc: qemu-stable@nongnu.org
Fixes: 4fb013afcc ("hw/misc/mps2-scc: Support configurable number of OSCCLK values") # v6.0.0+
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20231121174051.63038-4-philmd@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/misc/mps2-scc.c