OSDN Git Service

hw/xen: fix off-by-one in xen_evtchn_set_gsi()
authorDavid Woodhouse <dwmw@amazon.co.uk>
Fri, 7 Apr 2023 15:12:00 +0000 (17:12 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 1 Aug 2023 21:40:30 +0000 (23:40 +0200)
commitcf885b19579646d6a085470658bc83432d6786d2
tree6c875e372799901339b66e174a51d0ac94b07ccf
parent802341823f1720511dd5cf53ae40285f7978c61b
hw/xen: fix off-by-one in xen_evtchn_set_gsi()

Coverity points out (CID 1508128) a bounds checking error. We need to check
for gsi >= IOAPIC_NUM_PINS, not just greater-than.

Also fix up an assert() that has the same problem, that Coverity didn't see.

Fixes: 4f81baa33ed6 ("hw/xen: Support GSI mapping to PIRQ")
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230801175747.145906-2-dwmw2@infradead.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/i386/kvm/xen_evtchn.c