OSDN Git Service

ALSA: vmaster: Propagate slave error
authorTakashi Iwai <tiwai@suse.de>
Thu, 8 Mar 2018 07:26:48 +0000 (08:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:49:13 +0000 (07:49 +0200)
commit6eff7dc944faa9abd810fa9fcd5955e4b7fc7a28
tree1a16e48b3686684aba91c2d1574b1ecc600918c2
parentcd425208a5c80fdedd640137afeb5c452e1ec9a9
ALSA: vmaster: Propagate slave error

[ Upstream commit 2e2c177ca84aff092c3c96714b0f6a12900f3946 ]

In slave_update() of vmaster code ignores the error from the slave
get() callback and copies the values.  It's not only about the missing
error code but also that this may potentially lead to a leak of
uninitialized variables when the slave get() don't clear them.

This patch fixes slave_update() not to copy the potentially
uninitialized values when an error is returned from the slave get()
callback, and to propagate the error value properly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/vmaster.c