OSDN Git Service

ALSA: hda - Serialize codec registrations
authorTakashi Iwai <tiwai@suse.de>
Wed, 30 Jan 2019 16:46:03 +0000 (17:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Feb 2019 09:13:16 +0000 (10:13 +0100)
commit71ce2e8957ff6eed31953f54a02fc3bd083f0d26
tree42e0f6f0cb8cb750b5cd2228105e3c18a7cbf0b3
parentd7204d3860ee12f1d3da9680e9f25afa9ad65c1f
ALSA: hda - Serialize codec registrations

commit 305a0ade180981686eec1f92aa6252a7c6ebb1cf upstream.

In the current code, the codec registration may happen both at the
codec bind time and the end of the controller probe time.  In a rare
occasion, they race with each other, leading to Oops due to the still
uninitialized card device.

This patch introduces a simple flag to prevent the codec registration
at the codec bind time as long as the controller probe is going on.
The controller probe invokes snd_card_register() that does the whole
registration task, and we don't need to register each piece
beforehand.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/hda_bind.c
sound/pci/hda/hda_codec.h
sound/pci/hda/hda_intel.c