OSDN Git Service

crypto: gcm - wait for crypto op not signal safe
authorGilad Ben-Yossef <gilad@benyossef.com>
Thu, 18 May 2017 13:29:25 +0000 (16:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jun 2017 11:16:21 +0000 (13:16 +0200)
commita3a3a1cf538c024a4586c6c3396454d71df9b6b5
tree1c582a32340ea4a238754e130a98f03cfd048990
parent8096a6748a92b3d6671d3a116abe3fb75b8e463b
crypto: gcm - wait for crypto op not signal safe

commit f3ad587070d6bd961ab942b3fd7a85d00dfc934b upstream.

crypto_gcm_setkey() was using wait_for_completion_interruptible() to
wait for completion of async crypto op but if a signal occurs it
may return before DMA ops of HW crypto provider finish, thus
corrupting the data buffer that is kfree'ed in this case.

Resolve this by using wait_for_completion() instead.

Reported-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto/gcm.c