OSDN Git Service

ARM: OMAP1: ams-delta: Fix possible use of uninitialized field
authorJanusz Krzysztofik <jmkrzyszt@gmail.com>
Wed, 7 Nov 2018 21:30:31 +0000 (22:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 20:55:09 +0000 (21:55 +0100)
commitd7589b83d628eeb0850d61c354dbf47e15befc10
tree68cdda2eb186c2ab9225f03c40f7b300f0ad304c
parentd2f642b05832f54e46bb7cc601068038c27901ea
ARM: OMAP1: ams-delta: Fix possible use of uninitialized field

[ Upstream commit cec83ff1241ec98113a19385ea9e9cfa9aa4125b ]

While playing with initialization order of modem device, it has been
discovered that under some circumstances (early console init, I
believe) its .pm() callback may be called before the
uart_port->private_data pointer is initialized from
plat_serial8250_port->private_data, resulting in NULL pointer
dereference.  Fix it by checking for uninitialized pointer before using
it in modem_pm().

Fixes: aabf31737a6a ("ARM: OMAP1: ams-delta: update the modem to use regulator API")
Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/mach-omap1/board-ams-delta.c