OSDN Git Service

ALSA: seq: Cover unsubscribe_port() in list_mutex
authorTakashi Iwai <tiwai@suse.de>
Fri, 12 Apr 2019 09:37:19 +0000 (11:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Jun 2019 06:18:22 +0000 (08:18 +0200)
commitd7a18814fff90463b82247d1c29802d88d0760cf
tree4e31c9dcf3dddcda40cfe6a278fb226c0fbc9262
parent4282a0b1db65996ec8231cc8807fe04c9113876e
ALSA: seq: Cover unsubscribe_port() in list_mutex

commit 7c32ae35fbf9cffb7aa3736f44dec10c944ca18e upstream.

The call of unsubscribe_port() which manages the group count and
module refcount from delete_and_unsubscribe_port() looks racy; it's
not covered by the group list lock, and it's likely a cause of the
reported unbalance at port deletion.  Let's move the call inside the
group list_mutex to plug the hole.

Reported-by: syzbot+e4c8abb920efa77bace9@syzkaller.appspotmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/seq/seq_ports.c