OSDN Git Service

net: bgmac: Remove superflous netif_carrier_on()
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 23 Jun 2016 21:25:33 +0000 (14:25 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:37:18 +0000 (14:37 +0200)
commite1db592de73543db89d248c69b5b239be0ee5d2d
tree1f0785be39e01a12f73be0151d6c92b8b1ff08e0
parente66647f0e1ff59a3a335112d6cef70b21e8094c1
net: bgmac: Remove superflous netif_carrier_on()

commit 3894396e64994f31c3ef5c7e6f63dded0593e567 upstream.

bgmac_open() calls phy_start() to initialize the PHY state machine,
which will set the interface's carrier state accordingly, no need to
force that as this could be conflicting with the PHY state determined by
PHYLIB.

Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bgmac.c