OSDN Git Service

power: supply: ltc2941-battery-gauge: fix use-after-free
authorSven Van Asbroeck <thesven73@gmail.com>
Thu, 19 Sep 2019 15:11:37 +0000 (11:11 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Feb 2020 21:29:56 +0000 (16:29 -0500)
commitfd97ed8c874dc479d868ad33311ad227ff0c98ee
tree568d41fa46edfa0f58b6dee09af8ac4043110552
parent8885e4fb7ac511b56778549fbaeff22b72b1d7c2
power: supply: ltc2941-battery-gauge: fix use-after-free

commit a60ec78d306c6548d4adbc7918b587a723c555cc upstream.

This driver's remove path calls cancel_delayed_work().
However, that function does not wait until the work function
finishes. This could mean that the work function is still
running after the driver's remove function has finished,
which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
that the work is properly cancelled, no longer running, and
unable to re-schedule itself.

This issue was detected with the help of Coccinelle.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/ltc2941-battery-gauge.c