OSDN Git Service

ncpfs: don't allow negative timeouts
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 20 Nov 2015 23:56:56 +0000 (15:56 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 21 Nov 2015 00:17:32 +0000 (16:17 -0800)
commit1491e30ed1a741009d1d38f9285f7a29e6c05c78
tree6a1282ea4dd9ae029ce8cb79092e89fca4dcc2ec
parent5cf6a51e6062afe7cc507f32f1e5f7e6497ae844
ncpfs: don't allow negative timeouts

This code causes a static checker warning because it's a user controlled
variable where we cap the upper bound but not the lower bound.  Let's
return an -EINVAL for negative timeouts.

[akpm@linux-foundation.org: remove unneeded `else']
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Jan Kara <jack@suse.com>
Cc: Petr Vandrovec <petr@vandrovec.name>
Cc: David Howells <dhowells@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ncpfs/ioctl.c