OSDN Git Service

drm/i915: Only access SFC_DONE when media domain is not fused off
authorMatt Roper <matthew.d.roper@intel.com>
Fri, 6 Aug 2021 17:41:30 +0000 (10:41 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 12 Aug 2021 10:04:38 +0000 (06:04 -0400)
commit24d032e2359e3abc926b3d423f49a7c33e0b7836
treeaddad627a99ba9beab830cf977545329ea170538
parentabd9d66a055722393d33685214c08386694871d7
drm/i915: Only access SFC_DONE when media domain is not fused off

The SFC_DONE register lives within the corresponding VD0/VD2/VD4/VD6
forcewake domain and is not accessible if the vdbox in that domain is
fused off and the forcewake is not initialized.

This mistake went unnoticed because until recently we were using the
wrong register offset for the SFC_DONE register; once the register
offset was corrected, we started hitting errors like

  <4> [544.989065] i915 0000:cc:00.0: Uninitialized forcewake domain(s) 0x80 accessed at 0x1ce000

on parts with fused-off vdbox engines.

Fixes: e50dbdbfd9fb ("drm/i915/tgl: Add SFC instdone to error state")
Fixes: 9c9c6d0ab08a ("drm/i915: Correct SFC_DONE register offset")
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210806174130.1058960-1-matthew.d.roper@intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
(cherry picked from commit c5589bb5dccb0c5cb74910da93663f489589f3ce)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
[Changed Fixes tag to match the cherry-picked 82929a2140eb]
drivers/gpu/drm/i915/i915_gpu_error.c