OSDN Git Service

fs: don't assume arguments are non-NULL
authorChristian Brauner <brauner@kernel.org>
Mon, 3 Jul 2023 14:49:12 +0000 (16:49 +0200)
committerChristian Brauner <brauner@kernel.org>
Tue, 4 Jul 2023 08:21:11 +0000 (10:21 +0200)
commit33ab231f83cc12d0157711bbf84e180c3be7d7bc
tree68583c47b8f059d999c7d869c1a1ae3be8c6af78
parent66d8fc0539b0d49941f313c9509a8384e4245ac1
fs: don't assume arguments are non-NULL

The helper is explicitly documented as locking zero, one, or two
arguments. While all current callers do pass non-NULL arguments there's
no need or requirement for them to do so according to the code and the
unlock_two_nondirectories() helper is pretty clear about it as well. So
only call WARN_ON_ONCE() if the checked inode is valid.

Fixes: 2454ad83b90a ("fs: Restrict lock_two_nondirectories() to non-directory inodes")
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Jan Kara <jack@suse.cz>
Message-Id: <20230703-vfs-rename-source-v1-2-37eebb29b65b@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/inode.c