OSDN Git Service

x86/insn, tools/x86: Fix undefined behavior due to potential unaligned accesses
authorNumfor Mbiziwo-Tiapo <nums@google.com>
Thu, 23 Sep 2021 16:18:43 +0000 (09:18 -0700)
committerBorislav Petkov <bp@suse.de>
Fri, 24 Sep 2021 10:37:38 +0000 (12:37 +0200)
commit5ba1071f7554c4027bdbd712a146111de57918de
treea8b9d04fc9a87bdae3e91db1d9a42e3547f4b0c0
parentd81ff5fe14a950f53e2833cfa196e7bb3fd5d4e3
x86/insn, tools/x86: Fix undefined behavior due to potential unaligned accesses

Don't perform unaligned loads in __get_next() and __peek_nbyte_next() as
these are forms of undefined behavior:

"A pointer to an object or incomplete type may be converted to a pointer
to a different object or incomplete type. If the resulting pointer
is not correctly aligned for the pointed-to type, the behavior is
undefined."

(from http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf)

These problems were identified using the undefined behavior sanitizer
(ubsan) with the tools version of the code and perf test.

 [ bp: Massage commit message. ]

Signed-off-by: Numfor Mbiziwo-Tiapo <nums@google.com>
Signed-off-by: Ian Rogers <irogers@google.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lkml.kernel.org/r/20210923161843.751834-1-irogers@google.com
arch/x86/lib/insn.c
tools/arch/x86/lib/insn.c