OSDN Git Service

xfs: fix misuse of the XFS_ATTR_INCOMPLETE flag
authorChristoph Hellwig <hch@lst.de>
Tue, 7 Jan 2020 23:25:39 +0000 (15:25 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 9 Jan 2020 18:55:18 +0000 (10:55 -0800)
commit780d29057781d986cd87dbbe232cd02876ad430f
treed4e9b2b48e7679baf585ceaccf0d46c8d172bf69
parent8cde9f259c7d91d05b12cc68993a9643d6b4e45f
xfs: fix misuse of the XFS_ATTR_INCOMPLETE flag

XFS_ATTR_INCOMPLETE is a flag in the on-disk attribute format, and thus
in a different namespace as the ATTR_* flags in xfs_da_args.flags.
Switch to using a XFS_DA_OP_INCOMPLETE flag in op_flags instead.  Without
this users might be able to inject this flag into operations using the
attr by handle ioctl.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_attr.c
fs/xfs/libxfs/xfs_attr_leaf.c
fs/xfs/libxfs/xfs_da_btree.h
fs/xfs/libxfs/xfs_da_format.h