OSDN Git Service

vti: do not confirm neighbor when do pmtu update
authorHangbin Liu <liuhangbin@gmail.com>
Sun, 22 Dec 2019 02:51:14 +0000 (10:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Dec 2019 06:28:55 +0000 (22:28 -0800)
commit8247a79efa2f28b44329f363272550c1738377de
tree10426bd9fa86b7893fd965beff8fb917b58e24ca
parent7a1592bcb15d71400a98632727791d1e68ea0ee8
vti: do not confirm neighbor when do pmtu update

When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
we should not call dst_confirm_neigh() as there is no two-way communication.

Although vti and vti6 are immune to this problem because they are IFF_NOARP
interfaces, as Guillaume pointed. There is still no sense to confirm neighbour
here.

v5: Update commit description.
v4: No change.
v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
    dst_ops.update_pmtu to control whether we should do neighbor confirm.
    Also split the big patch to small ones for each area.
v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.

Reviewed-by: Guillaume Nault <gnault@redhat.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_vti.c
net/ipv6/ip6_vti.c