OSDN Git Service

crypto: remove CRYPTO_TFM_RES_WEAK_KEY
authorEric Biggers <ebiggers@google.com>
Tue, 31 Dec 2019 03:19:37 +0000 (21:19 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 9 Jan 2020 03:30:53 +0000 (11:30 +0800)
commitc4c4db0d59774f6ab726edd012711490437345c2
treed98651b23aa678635398be4a09d12696ab924162
parent674f368a952c48ede71784935a799a5205b92b6c
crypto: remove CRYPTO_TFM_RES_WEAK_KEY

The CRYPTO_TFM_RES_WEAK_KEY flag was apparently meant as a way to make
the ->setkey() functions provide more information about errors.

However, no one actually checks for this flag, which makes it pointless.
There are also no tests that verify that all algorithms actually set (or
don't set) it correctly.

This is also the last remaining CRYPTO_TFM_RES_* flag, which means that
it's the only thing still needing all the boilerplate code which
propagates these flags around from child => parent tfms.

And if someone ever needs to distinguish this error in the future (which
is somewhat unlikely, as it's been unneeded for a long time), it would
be much better to just define a new return value like -EKEYREJECTED.
That would be much simpler, less error-prone, and easier to test.

So just remove this flag.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/des_generic.c
drivers/crypto/ixp4xx_crypto.c
include/crypto/internal/des.h
include/crypto/xts.h
include/linux/crypto.h