OSDN Git Service

pkt_sched: fq: do not accept silly TCA_FQ_QUANTUM
authorEric Dumazet <edumazet@google.com>
Mon, 6 Jan 2020 14:10:39 +0000 (06:10 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Jan 2020 20:40:47 +0000 (12:40 -0800)
commitd9e15a2733067c9328fb56d98fe8e574fa19ec31
treefcba680930ee393e0c16aa75b782975674cba89c
parentb969fee12b6330fd6a0b15337a314d5b5ee56916
pkt_sched: fq: do not accept silly TCA_FQ_QUANTUM

As diagnosed by Florian :

If TCA_FQ_QUANTUM is set to 0x80000000, fq_deueue()
can loop forever in :

if (f->credit <= 0) {
  f->credit += q->quantum;
  goto begin;
}

... because f->credit is either 0 or -2147483648.

Let's limit TCA_FQ_QUANTUM to no more than 1 << 20 :
This max value should limit risks of breaking user setups
while fixing this bug.

Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Diagnosed-by: Florian Westphal <fw@strlen.de>
Reported-by: syzbot+dc9071cc5a85950bdfce@syzkaller.appspotmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_fq.c