OSDN Git Service

net/mlx5e: Fix fixpoint divide exception in mlx5e_am_stats_compare
authorTalat Batheesh <talatb@mellanox.com>
Sun, 21 Jan 2018 03:30:42 +0000 (05:30 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 21 Jan 2018 23:06:33 +0000 (18:06 -0500)
commite58edaa4863583b54409444f11b4f80dff0af1cd
tree324a371756a3352eabd8badbe3e209d5c7719d34
parentec835f8104a21f4d4eeb9d316ee71d2b4a7f00de
net/mlx5e: Fix fixpoint divide exception in mlx5e_am_stats_compare

Helmut reported a bug about division by zero while
running traffic and doing physical cable pull test.

When the cable unplugged the ppms become zero, so when
dividing the current ppms by the previous ppms in the
next dim iteration there is division by zero.

This patch prevent this division for both ppms and epms.

Fixes: c3164d2fc48f ("net/mlx5e: Added BW check for DIM decision mechanism")
Reported-by: Helmut Grauer <helmut.grauer@de.ibm.com>
Signed-off-by: Talat Batheesh <talatb@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_rx_am.c