OSDN Git Service

tcp-zerocopy: Return sk_err (if set) along with tcp receive zerocopy.
authorArjun Roy <arjunroy@google.com>
Fri, 14 Feb 2020 23:30:50 +0000 (15:30 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Feb 2020 03:25:02 +0000 (19:25 -0800)
commit33946518d493cdf10aedb4a483f1aa41948a3dab
treeac31781461616de8689ed71d153a29ae8b8523ee
parentc8856c051454909e5059df4e81c77b9c366c5515
tcp-zerocopy: Return sk_err (if set) along with tcp receive zerocopy.

This patchset is intended to reduce the number of extra system calls
imposed by TCP receive zerocopy. For ping-pong RPC style workloads,
this patchset has demonstrated a system call reduction of about 30%
when coupled with userspace changes.

For applications using epoll, returning sk_err along with the result
of tcp receive zerocopy could remove the need to call
recvmsg()=-EAGAIN after a spurious wakeup.

Consider a multi-threaded application using epoll. A thread may awaken
with EPOLLIN but another thread may already be reading. The
spuriously-awoken thread does not necessarily know that another thread
'won'; rather, it may be possible that it was woken up due to the
presence of an error if there is no data. A zerocopy read receiving 0
bytes thus would need to be followed up by recvmsg to be sure.

Instead, we return sk_err directly with zerocopy, so the application
can avoid this extra system call.

Signed-off-by: Arjun Roy <arjunroy@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/uapi/linux/tcp.h
net/ipv4/tcp.c