OSDN Git Service

net_sched: fix a memory leak in cls_tcindex
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 11 Feb 2019 21:06:15 +0000 (13:06 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Feb 2019 19:10:56 +0000 (14:10 -0500)
commit033b228e7f26b29ae37f8bfa1bc6b209a5365e9f
tree920a6c9cb1fa841c160cbc4befc569ce1f7d4d1d
parent8015d93ebd27484418d4952284fd02172fa4b0b2
net_sched: fix a memory leak in cls_tcindex

When tcindex_destroy() destroys all the filter results in
the perfect hash table, it invokes the walker to delete
each of them. However, results with class==0 are skipped
in either tcindex_walk() or tcindex_delete(), which causes
a memory leak reported by kmemleak.

This patch fixes it by skipping the walker and directly
deleting these filter results so we don't miss any filter
result.

As a result of this change, we have to initialize exts->net
properly in tcindex_alloc_perfect_hash(). For net-next, we
need to consider whether we should initialize ->net in
tcf_exts_init() instead, before that just directly test
CONFIG_NET_CLS_ACT=y.

Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_tcindex.c