OSDN Git Service

cxl: Check if afu is not null in cxl_slbia
authorDaniel Axtens <dja@axtens.net>
Thu, 9 Jul 2015 23:04:25 +0000 (09:04 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 10 Jul 2015 01:44:25 +0000 (11:44 +1000)
commit2c069a118fe1d80c47dca84e1561045fc7f3cc9e
treeba055083f9ddb839ae809f48015d7d0eafa9cfa5
parent9958084a5275ca2e8f55c5b18729307f2f0cb53b
cxl: Check if afu is not null in cxl_slbia

The pointer to an AFU in the adapter's list of AFUs can be null
if we're in the process of removing AFUs. The afu_list_lock
doesn't guard against this.

Say we have 2 slices, and we're in the process of removing cxl.
 - We remove the AFUs in order (see cxl_remove). In cxl_remove_afu
   for AFU 0, we take the lock, set adapter->afu[0] = NULL, and
   release the lock.
 - Then we get an slbia. In cxl_slbia we take the lock, and set
   afu = adapter->afu[0], which is NULL.
 - Therefore our attempt to check afu->enabled will blow up.

Therefore, check if afu is a null pointer before dereferencing it.

Cc: stable@vger.kernel.org
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Michael Neuling <mikey@neuling.org>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/misc/cxl/main.c