OSDN Git Service

drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open
authorGrygorii Strashko <grygorii.strashko@ti.com>
Tue, 19 Apr 2016 18:09:49 +0000 (21:09 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Apr 2016 18:30:39 +0000 (14:30 -0400)
commit3fa88c51c73a67e7eeda1fcafd809f9185790b31
treeb194e1c8644ce195912937929ef6d0d4d9d547fa
parent479f85c36688f5c855ad463b71902ef5992628b7
drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open

The cpsw_ndo_open() could try to access CPSW registers before
calling pm_runtime_get_sync(). This will trigger L3 error:

 WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c()
 44000000.ocp:L3 Custom Error: MASTER M2 (64-bit) TARGET L4_FAST (Idle): Data Access in Supervisor mode during Functional access

and CPSW will stop functioning.

Hence, fix it by moving pm_runtime_get_sync() before the first access
to CPSW registers in cpsw_ndo_open().

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c