OSDN Git Service

i2c: exynos5: Properly use the "noirq" variants of suspend/resume
authorDoug Anderson <dianders@chromium.org>
Wed, 25 Jun 2014 16:39:20 +0000 (09:39 -0700)
committerWolfram Sang <wsa@the-dreams.de>
Wed, 16 Jul 2014 21:00:09 +0000 (23:00 +0200)
commit57186fe3db3ec462065a9fab41344a9d78785ad9
tree4f9f2ef2f3a824c19b6fbdedff77a3d255c6fbb8
parent4db5beed9cc9756fd5f2bdba381115d4b7a7d286
i2c: exynos5: Properly use the "noirq" variants of suspend/resume

The original code for the exynos i2c controller registered for the
"noirq" variants.  However during review feedback it was moved to
SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no
longer actually "noirq" (despite functions named
exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq).

i2c controllers that might have wakeup sources on them seem to need to
resume at noirq time so that the individual drivers can actually read
the i2c bus to handle their wakeup.

NOTE: I took the original review feedback from Wolfram and added
poweroff, thaw, freeze, restore.

This patch has only been compile-tested since I don't have all the
patches needed to make my machine using this i2c driver actually
suspend/resume.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-exynos5.c