OSDN Git Service

ice: initialize local variable 'tlv'
authorTom Rix <trix@redhat.com>
Mon, 14 Feb 2022 15:40:43 +0000 (07:40 -0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 18 Feb 2022 21:28:39 +0000 (13:28 -0800)
commit5950bdc88dd1d158f2845fdff8fb1de86476806c
tree3c836646eb2ee0634a4f52e1eb0f78b08db1c2ce
parented22d9c8d128293fc7b0b086c7d3654bcb99a8dd
ice: initialize local variable 'tlv'

Clang static analysis reports this issues
ice_common.c:5008:21: warning: The left expression of the compound
  assignment is an uninitialized value. The computed value will
  also be garbage
  ldo->phy_type_low |= ((u64)buf << (i * 16));
  ~~~~~~~~~~~~~~~~~ ^

When called from ice_cfg_phy_fec() ldo is the uninitialized local
variable tlv.  So initialize.

Fixes: ea78ce4dab05 ("ice: add link lenient and default override support")
Signed-off-by: Tom Rix <trix@redhat.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_common.c