OSDN Git Service

phonet: fix building with clang
authorArnd Bergmann <arnd@arndb.de>
Tue, 19 Feb 2019 21:53:50 +0000 (22:53 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Feb 2019 00:23:56 +0000 (16:23 -0800)
commit6321aa197547da397753757bd84c6ce64b3e3d89
tree74697a2e39836b2675d3998b2e7d071d001f381f
parentb35560e485cb3a10bfe631732bcb75fe1a568da7
phonet: fix building with clang

clang warns about overflowing the data[] member in the struct pnpipehdr:

net/phonet/pep.c:295:8: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
                        if (hdr->data[4] == PEP_IND_READY)
                            ^         ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
                u8              data[1];

Using a flexible array member at the end of the struct avoids the
warning, but since we cannot have a flexible array member inside
of the union, each index now has to be moved back by one, which
makes it a little uglier.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: RĂ©mi Denis-Courmont <remi@remlab.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/phonet/pep.h
net/phonet/pep.c