OSDN Git Service

usb: isp1760: fix spin unlock in the error path of isp1760_udc_start
authorSudeep Holla <sudeep.holla@arm.com>
Fri, 20 Mar 2015 11:42:17 +0000 (11:42 +0000)
committerFelipe Balbi <balbi@ti.com>
Tue, 24 Mar 2015 16:38:58 +0000 (11:38 -0500)
commit65582a7f4ce5bd7a1fb61516d9c2476f4f166f4e
treebf012c910c79c488b31dd66cb9aef4db76498bf3
parentbc465aa9d045feb0e13b4a8f32cc33c1943f62d6
usb: isp1760: fix spin unlock in the error path of isp1760_udc_start

Commit a124820de5fd ("usb: isp1760: fix possible deadlock in
isp1760_udc_irq") replaced spin_{un,}lock with spin_{un,}lock_irq{save,restore}.
However it missed an error path resulting in the smatch warning as below:

drivers/usb/isp1760/isp1760-udc.c:1230 isp1760_udc_start() warn: inconsistent returns 'irqsave:flags'.
Locked on:   line 1207
Unlocked on: line 1199

This patch fixes the spin unlock in the error path in isp1760_udc_start
thereby removing the smatch warning mentioned above.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/isp1760/isp1760-udc.c