OSDN Git Service

filemap: add a comment about FAULT_FLAG_RETRY_NOWAIT behavior
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 15 Mar 2019 18:26:07 +0000 (11:26 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 15 Mar 2019 18:26:07 +0000 (11:26 -0700)
commit8b0f9fa2e02dc95216577c3387b0707c5f60fbaf
tree8cb433d3c8ae7ecf8bf64dcb69dbfff2b350afa1
parent6b4c9f4469819a0c1a38a0a4541337e0f9bf6c11
filemap: add a comment about FAULT_FLAG_RETRY_NOWAIT behavior

I thought Josef Bacik's patch to drop the mmap_sem was buggy, because
when looking at the error cases, there was one case where we returned
VM_FAULT_RETRY without actually dropping the mmap_sem.

Josef had to explain to me (using small words) that yes, that's actually
what we're supposed to do, and his patch was correct.  Which not only
convinced me he knew what he was doing and I should stop arguing with
him, but also that I should add a comment to the case I was confused
about.

Patiently-pointed-out-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/filemap.c