OSDN Git Service

scsi: aacraid: fix PCI error recovery path
authorGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Thu, 6 Apr 2017 21:12:09 +0000 (18:12 -0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 12 Apr 2017 00:45:59 +0000 (20:45 -0400)
commit911e572e98656056ebbbb4274d8fe61434188646
treef042c0d9b613642141bef22c742fdb89b09d2e91
parent7c856152cb92f8eee2df29ef325a1b1f43161aff
scsi: aacraid: fix PCI error recovery path

During a PCI error recovery, if aac_check_health() is not aware that a
PCI error happened and we have an offline PCI channel, it might trigger
some errors (like NULL pointer dereference) and inhibit the error
recovery process to complete.

This patch makes the health check procedure aware of PCI channel issues,
and in case of error recovery process, the function
aac_adapter_check_health() returns -1 and let the recovery process to
complete successfully. This patch was tested on upstream kernel
v4.11-rc5 in PowerPC ppc64le architecture with adapter 9005:028d
(VID:DID) - the error recovery procedure was able to recover fine.

Fixes: 5c63f7f710bd ("aacraid: Added EEH support")
Cc: stable@vger.kernel.org # v4.6+
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Reviewed-by: Dave Carroll <david.carroll@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aacraid/aacraid.h
drivers/scsi/aacraid/commsup.c