OSDN Git Service

mfd: twl4030: Don't warn about uninitialized return code
authorArnd Bergmann <arnd@arndb.de>
Fri, 25 Jan 2013 14:14:26 +0000 (14:14 +0000)
committerSamuel Ortiz <sameo@linux.intel.com>
Sun, 27 Jan 2013 01:18:01 +0000 (02:18 +0100)
commitf65e9eacfad60cd05d1bac7defb6ff6b50dcfb5b
tree5d44d49b4b471f5aa715549298bce6128a10830f
parent0a8c290ac58a86d5e1f2193abcd4d74ec075e20c
mfd: twl4030: Don't warn about uninitialized return code

If the twl4030_write_script function gets called with
a zero length argument, its return value does not
get set. We know that all scripts have a nonzero
length, but returning an error in case they ever
do is probably appropriate.

Without this patch, building omap2plus_defconfig results in:

drivers/mfd/twl4030-power.c: In function 'load_twl4030_script':
drivers/mfd/twl4030-power.c:414:5: error: 'err' may be used uninitialized in this function

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "Kristo, Tero" <t-kristo@ti.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/twl4030-power.c