OSDN Git Service

net/x25: Fix x25_neigh refcnt leak when x25 disconnect
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Sat, 25 Apr 2020 13:06:25 +0000 (21:06 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Apr 2020 18:20:30 +0000 (11:20 -0700)
commit4becb7ee5b3d2829ed7b9261a245a77d5b7de902
tree4787f195bcdbb76ec58114be47c1cf90107f81e6
parent095f5614bfe16e5b3e191b34ea41b10d6fdd4ced
net/x25: Fix x25_neigh refcnt leak when x25 disconnect

x25_connect() invokes x25_get_neigh(), which returns a reference of the
specified x25_neigh object to "x25->neighbour" with increased refcnt.

When x25 connect success and returns, the reference still be hold by
"x25->neighbour", so the refcount should be decreased in
x25_disconnect() to keep refcount balanced.

The reference counting issue happens in x25_disconnect(), which forgets
to decrease the refcnt increased by x25_get_neigh() in x25_connect(),
causing a refcnt leak.

Fix this issue by calling x25_neigh_put() before x25_disconnect()
returns.

Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/x25_subr.c