OSDN Git Service

block: don't deal with discard limit in blkdev_issue_discard()
authorMing Lei <ming.lei@redhat.com>
Fri, 12 Oct 2018 07:53:10 +0000 (15:53 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 18 Oct 2018 13:23:40 +0000 (07:23 -0600)
commit744889b7cbb56a64f957e65ade7cb65fe3f35714
tree65972a4045c33b737862a4522271ec5705f41e2c
parent7a7080b53467ad96c0b371e9d2a2a312f96f99c2
block: don't deal with discard limit in blkdev_issue_discard()

blk_queue_split() does respect this limit via bio splitting, so no
need to do that in blkdev_issue_discard(), then we can align to
normal bio submit(bio_add_page() & submit_bio()).

More importantly, this patch fixes one issue introduced in a22c4d7e34402cc
("block: re-add discard_granularity and alignment checks"), in which
zero discard bio may be generated in case of zero alignment.

Fixes: a22c4d7e34402ccdf3 ("block: re-add discard_granularity and alignment checks")
Cc: stable@vger.kernel.org
Cc: Ming Lin <ming.l@ssi.samsung.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Xiao Ni <xni@redhat.com>
Tested-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-lib.c