Del signature from cache when added to the block (#258)

[bytom/vapor.git] / blockchain / txbuilder / finalize.go

diff --git a/blockchain/txbuilder/finalize.go b/blockchain/txbuilder/finalize.go
index daa6308..577830f 100644 (file)
--- a/blockchain/txbuilder/finalize.go
+++ b/blockchain/txbuilder/finalize.go
@@ -4,9 +4,10 @@ import (
        "bytes"
        "context"
 
+       "github.com/vapor/common/arithmetic"
        cfg "github.com/vapor/config"
-       "github.com/vapor/consensus"
        "github.com/vapor/errors"
+       "github.com/vapor/math/checked"
        "github.com/vapor/protocol"
        "github.com/vapor/protocol/bc/types"
        "github.com/vapor/protocol/vm"
@@ -23,13 +24,17 @@ var (
        ErrOrphanTx = errors.New("finalize can't find transaction input utxo")
        // ErrExtTxFee means transaction fee exceed max limit
        ErrExtTxFee = errors.New("transaction fee exceed max limit")
+       // ErrNoGasInput means transaction has no gas input
+       ErrNoGasInput = errors.New("transaction has no gas input")
 )
 
 // FinalizeTx validates a transaction signature template,
 // assembles a fully signed tx, and stores the effects of
 // its changes on the UTXO set.
 func FinalizeTx(ctx context.Context, c *protocol.Chain, tx *types.Tx) error {
-       if fee := CalculateTxFee(tx); fee > cfg.CommonConfig.Wallet.MaxTxFee {
+       if fee, err := arithmetic.CalculateTxFee(tx); err != nil {
+               return checked.ErrOverflow
+       } else if fee > cfg.CommonConfig.Wallet.MaxTxFee {
                return ErrExtTxFee
        }
 
@@ -37,13 +42,18 @@ func FinalizeTx(ctx context.Context, c *protocol.Chain, tx *types.Tx) error {
                return err
        }
 
+       if err := checkGasInputIDs(tx); err != nil {
+               return err
+       }
+
        // This part is use for prevent tx size  is 0
        data, err := tx.TxData.MarshalText()
        if err != nil {
                return err
        }
-       tx.TxData.SerializedSize = uint64(len(data))
-       tx.Tx.SerializedSize = uint64(len(data))
+       tx.TxData.SerializedSize = uint64(len(data) / 2)
+       tx.Tx.SerializedSize = uint64(len(data) / 2)
+
        isOrphan, err := c.ValidateTx(tx)
        if errors.Root(err) == protocol.ErrBadTx {
                return errors.Sub(ErrRejected, err)
@@ -84,10 +94,6 @@ func checkTxSighashCommitment(tx *types.Tx) error {
                switch t := inp.TypedInput.(type) {
                case *types.SpendInput:
                        args = t.Arguments
-               case *types.IssuanceInput:
-                       args = t.Arguments
-               case *types.ClaimInput:
-                       args = t.Arguments
                }
                // Note: These numbers will need to change if more args are added such that the minimum length changes
                switch {
@@ -125,22 +131,16 @@ func checkTxSighashCommitment(tx *types.Tx) error {
        return lastError
 }
 
-// CalculateTxFee calculate transaction fee
-func CalculateTxFee(tx *types.Tx) (fee uint64) {
-       totalInputBTM := uint64(0)
-       totalOutputBTM := uint64(0)
-
-       for _, input := range tx.Inputs {
-               if input.InputType() != types.CoinbaseInputType && input.AssetID() == *consensus.BTMAssetID {
-                       totalInputBTM += input.Amount()
+func checkGasInputIDs(tx *types.Tx) error {
+       for _, inp := range tx.Inputs {
+               switch inp.InputType() {
+               case types.CrossChainInputType:
+                       return nil
                }
        }
 
-       for _, output := range tx.Outputs {
-               if *output.AssetId == *consensus.BTMAssetID {
-                       totalOutputBTM += output.Amount
-               }
+       if len(tx.GasInputIDs) == 0 {
+               return ErrNoGasInput
        }
-       fee = totalInputBTM - totalOutputBTM
-       return
+       return nil
 }