OSDN Git Service
Leon Scroggins [Mon, 14 Sep 2009 23:47:24 +0000 (19:47 -0400)]
When opening in a new tab in the background, restore the old tab position.
Fixes http://b/issue?id=
2114610
Change-Id: Ia2718ee5fe0f1fcf1d95ffceb45f9b632fd26099
Leon Scroggins [Mon, 14 Sep 2009 22:43:27 +0000 (18:43 -0400)]
Use a new resource for pages that do not have a screenshot in bookmarks.
Change-Id: Iff64adbd0549be5c182dd38a18c5fbeb5e88a1e8
Leon Scroggins [Fri, 11 Sep 2009 22:37:53 +0000 (18:37 -0400)]
Limit the touch area for opening search to the right edge of the textfield.
Now all single taps to the title bar will result in either
a search or opening the bookmarks picker, depending on whether
they were past the right edge of the textfield.
Fixes http://b/issue?id=
2113429
Also move the lock icon in between the favicon and the url. See
http://b/issue?id=
2085847
Change-Id: I30447aa7517b6fc801d3cf34eff233db3a4ce635
Android (Google) Code Review [Mon, 14 Sep 2009 20:04:51 +0000 (16:04 -0400)]
Merge change 24908 into eclair
* changes:
Show icons for storage and geolocation
Nicolas Roard [Mon, 14 Sep 2009 19:39:08 +0000 (20:39 +0100)]
Show icons for storage and geolocation
Leon Scroggins [Mon, 14 Sep 2009 16:58:04 +0000 (12:58 -0400)]
Show title bar while loading, and hide it when finished loading.
Fix for http://b/issue?id=
2107276
Change-Id: I96cb4d3bd71edeb38b3afc7e58a339021a81ed46
Ben Murdoch [Mon, 14 Sep 2009 09:48:24 +0000 (10:48 +0100)]
Add an options menu to the web site settings activity with just one option to clear all websites' storage/geolocation permissions.
Change-Id: Idbcf24f5340491e8d75353838c482bc2d5039da8
Leon Scroggins [Wed, 9 Sep 2009 16:51:10 +0000 (12:51 -0400)]
Show the title bar when pressing bringing up the menu.
Show an actionable title bar at the top of the screen when the
menu shows.
Change TitleBar* to take a Bitmap for setFavicon, and move the
logic for creating the drawable into TitleBar, so that we can
update directly from the WebView (whose getFavicon method returns
a bitmap).
Remove CUSTOM_BROWSER_BAR, since we are set on using our custom
title bar, and it enabled me to put mGenericFavicon in TitleBar.
Also take screen density into account when sizing the icons for
the title bar.
Change-Id: I3ee6b1d02e8845299f9cd1f648b271543683954a
Android (Google) Code Review [Fri, 11 Sep 2009 18:22:52 +0000 (14:22 -0400)]
Merge change 24688 into eclair
* changes:
Adjustments for the look of the tab page.
Leon Scroggins [Fri, 11 Sep 2009 15:12:58 +0000 (11:12 -0400)]
Adjustments for the look of the tab page.
Remove http://; center "New tab"
Use a drawable with a hi dpi version
Add some padding
Add a divider before the close button
Change-Id: I1e7c98e3e03f2a7b3c8df6db1917a604a6309fb8
Android (Google) Code Review [Fri, 11 Sep 2009 18:11:58 +0000 (14:11 -0400)]
Merge change 24694 into eclair
* changes:
Remove the active tabs page when pausing the BrowserActivity.
Leon Scroggins [Fri, 11 Sep 2009 15:49:52 +0000 (11:49 -0400)]
Remove the active tabs page when pausing the BrowserActivity.
This fixes http://b/issue?id=
2113505
Change-Id: Ibb66546a86082986170ec983c4e081008182baac
Android (Google) Code Review [Fri, 11 Sep 2009 17:17:20 +0000 (13:17 -0400)]
Merge change 24651 into eclair
* changes:
Always enable "OK" in the homepage dialog. If it is like "cnn.com", make it "http://cnn.com". If it has space or has colon, but doesn't match the acceptable schema, show an error dialog and don't take the invalid result.
Grace Kloba [Fri, 11 Sep 2009 04:28:18 +0000 (21:28 -0700)]
Always enable "OK" in the homepage dialog. If it is like "cnn.com",
make it "http://cnn.com". If it has space or has colon, but doesn't
match the acceptable schema, show an error dialog and don't take the
invalid result.
Fix http://b/issue?id=
2106155
Cary Clark [Thu, 10 Sep 2009 17:34:44 +0000 (13:34 -0400)]
allow mixed-case schemes in user-defined URLs
Adjust the scheme to all lower case before fixing the URL. This
allows mixed-case entries in bookmarks to resolve to a conical
lower case URL.
Android (Google) Code Review [Thu, 10 Sep 2009 20:39:55 +0000 (16:39 -0400)]
Merge change 24561 into eclair
* changes:
Remove the search bar from the bookmarks page.
Android (Google) Code Review [Thu, 10 Sep 2009 20:38:54 +0000 (16:38 -0400)]
Merge change 24566 into eclair
* changes:
Make the text in the title bar larger and centered.
Leon Scroggins [Thu, 10 Sep 2009 20:22:48 +0000 (16:22 -0400)]
Make the text in the title bar larger and centered.
Fixes http://b/issue?id=
2107393
Change-Id: Id9d959769e0fb988459c960c91ecd1fdb7064786
Leon Scroggins [Thu, 10 Sep 2009 19:16:01 +0000 (15:16 -0400)]
Remove the search bar from the bookmarks page.
Now that the bookmarks page is no longer the landing page, there is
no need to have a search bar at the top. Since there is now more
screen real estate, turn the mini-tabs back into regular tabs, and
return their icons. Also switch the states to look appropriate with
the new look of tabs.
Change-Id: I4cf3544753a16a57caf7a8cf1bf375008caad67c
Leon Scroggins [Tue, 8 Sep 2009 19:35:33 +0000 (15:35 -0400)]
Add an active tabs page.
The active tabs page gives the user the ability to see all of their
open tabs in a list, and switch tabs, create a new one, or close
an old one.
Fix for http://b/issue?id=
2101994
Change-Id: Id4c14dd437f769144dbdb02011144ea97d8fd030
Android (Google) Code Review [Thu, 10 Sep 2009 15:50:02 +0000 (11:50 -0400)]
Merge change 24521 into eclair
* changes:
Rounds up to the nearest 0.1MB when displaying the storage used by a website.
Steve Block [Thu, 10 Sep 2009 14:01:37 +0000 (15:01 +0100)]
Rounds up to the nearest 0.1MB when displaying the storage used by a website.
This fixes bug http://b/issue?id=
2024901.
Change-Id: Ifa8d12e3a5844c8e5b27ce9ddd817058257eabc6
Grace Kloba [Thu, 3 Sep 2009 23:29:56 +0000 (16:29 -0700)]
Remove clientid from the url before it is added to the database. So that we
won't show them in the auto-complete list.
Update the browser.db and remove history only entries who has clientid.
Fix http://b/issue?id=
2099727
Android (Google) Code Review [Wed, 9 Sep 2009 16:41:35 +0000 (12:41 -0400)]
Merge change 23974 into eclair
* changes:
allow file: scheme in the browser
Cary Clark [Fri, 4 Sep 2009 16:25:10 +0000 (12:25 -0400)]
allow file: scheme in the browser
When creating a bookmark, allow the book's URL to start with
javascript: . Use URI to isolate the scheme
to take care of case and special characters.
fixes http://b/issue?id=
2059889
Eric Fischer [Tue, 8 Sep 2009 23:24:45 +0000 (16:24 -0700)]
Import revised translations. DO NOT MERGE
Leon Scroggins [Tue, 8 Sep 2009 18:55:19 +0000 (14:55 -0400)]
Adjust the height of the mini-tabs to account for density.
Fix for http://b/issue?id=
2098612
Change-Id: Ieb905a35f0205e9bffe8cd790f01aa6b061f8bdc
Android (Google) Code Review [Tue, 8 Sep 2009 12:46:48 +0000 (05:46 -0700)]
Merge changes 23486,23988 into eclair
* changes:
Update the manifest to mark the activity as the default.
enable plugins to launch an activity within the browser
Leon Scroggins [Fri, 4 Sep 2009 22:36:20 +0000 (18:36 -0400)]
Go to the home page when opening a new tab/the browser.
As requested in http://b/issue?id=
2101999, we are going
back to opening the home page when opening the browser or
a new tab.
Change-Id: I2608bab74494a0af2919bf351340579bcd58201f
Leon Scroggins [Fri, 4 Sep 2009 21:00:08 +0000 (17:00 -0400)]
Clean up changes from attaching title bar to top of WebView
Renamed addTitleBar to setEmbeddedTitleBar. Requires a
change to frameworks/base
Change-Id: I0ea3c969dbd8c365a9f71eb373b11ddb0aa30b9b
Patrick Scott [Fri, 4 Sep 2009 13:51:45 +0000 (09:51 -0400)]
Update the manifest to mark the activity as the default.
This was needed during testing and threw an exception without it. Not sure how
Derek got around not having it before.
Leon Scroggins [Thu, 3 Sep 2009 19:08:54 +0000 (15:08 -0400)]
New title bar look.
Use the same method as the search bar for showing the circular
progress, which is much more visible than the current model.
Use latest assets.
Move the lock icon outside the textbox.
Change-Id: I7fd5911cb4492d3cd52132e817da75f720b42b55
Android (Google) Code Review [Thu, 3 Sep 2009 18:43:58 +0000 (11:43 -0700)]
Merge change 23812 into eclair
* changes:
Show the full url in the title bar.
Leon Scroggins [Thu, 3 Sep 2009 14:20:44 +0000 (10:20 -0400)]
Show the full url in the title bar.
Fix for http://b/issue?id=
2096235
Change-Id: I79d34c6e847587c63dc79b8c68813508eacaf9d5
Leon Scroggins [Thu, 3 Sep 2009 01:20:30 +0000 (21:20 -0400)]
Attach the title bar to the top of the page.
Remove the old notions of changing the viewing mode
resulting in changing the visibility of the title bar.
Instead, attach the title bar to the current WebView.
Requires a change to frameworks/base.
Change-Id: I65ba1182db040848700840e6229d7e1a7c6050d0
Xia Wang [Wed, 2 Sep 2009 20:51:34 +0000 (13:51 -0700)]
Revert "Add a test case in browser to measure the power usage of loading a web page"
This reverts commit
a4d616c5291877646558d954f5e3cc9733309b4c.
Android (Google) Code Review [Wed, 2 Sep 2009 19:43:25 +0000 (12:43 -0700)]
Merge change 23647 into eclair
* changes:
Add a test case in browser to measure the power usage of loading a web page
Xia Wang [Wed, 2 Sep 2009 04:50:48 +0000 (21:50 -0700)]
Add a test case in browser to measure the power usage of loading a web page
Android (Google) Code Review [Wed, 2 Sep 2009 17:56:28 +0000 (10:56 -0700)]
Merge change 23445 into eclair
* changes:
When removing a tab, go back to the correct parent tab.
Grace Kloba [Tue, 1 Sep 2009 07:56:09 +0000 (00:56 -0700)]
When we close a window on exit, make sure pauseWebView taking action by
setting mPageStarted to false.
Part 1 for fixing http://b/issue?id=
2087410
Derek Sollenberger [Tue, 1 Sep 2009 20:24:08 +0000 (16:24 -0400)]
enable plugins to launch an activity within the browser
Change-Id: Ife459b2d248a2ce0c0a4de3f69b74c86ee472266
Leon Scroggins [Tue, 1 Sep 2009 16:33:07 +0000 (12:33 -0400)]
When removing a tab, go back to the correct parent tab.
Fix for http://b/issue?id=
2075182 . We re-set the Adapter so
that it refreshes itself. Before calling removeTab, we set
the selection to the correct one. Keep track of that selection
and set it again after re-setting the Adapter.
Change-Id: I2dd07dd9bbf5f2abbbf99e004b5c37560495ec3a
Android (Google) Code Review [Tue, 1 Sep 2009 16:19:11 +0000 (09:19 -0700)]
Merge change 23440 into eclair
* changes:
allow adding content: bookmarks
Cary Clark [Tue, 1 Sep 2009 15:45:37 +0000 (11:45 -0400)]
allow adding content: bookmarks
Leon Scroggins [Mon, 31 Aug 2009 21:05:41 +0000 (17:05 -0400)]
Update the appearance of the title bar in the browser.
Change the title bar to use the look of the search bar. Remove
the new tab button, which is now a part of the updated menu. Make
the title bar for each WebView span the width of the screen. Make
the title bar appear when pressing the menu button.
Change-Id: I7ad1c955412d422be0fc6f26ec8d286172a0a99a
Patrick Scott [Tue, 25 Aug 2009 17:52:46 +0000 (13:52 -0400)]
Use the new code values for onReceivedError.
Patrick Scott [Mon, 31 Aug 2009 18:31:52 +0000 (14:31 -0400)]
Do not include ourselves as a candidate for downloading content.
If we are attempting to download a file and try to resolve to another activity,
it is possible to get BrowserActivity as the best candidate. In that case, we
need to fall back to the download manager. If we do not, we end up in a loop
trying to download the file and sending ourselves a new intent.
BUG:
2062310
Patrick Scott [Mon, 31 Aug 2009 13:48:37 +0000 (09:48 -0400)]
Check for null tabs before acquiring the parent tab.
This prevents a NPE when the current tab is null. This is very rare but can
still possibly happen.
Android (Google) Code Review [Fri, 28 Aug 2009 20:13:15 +0000 (13:13 -0700)]
Merge change 23134 into eclair
* changes:
High-resolution (hdpi) artwork from TAT for Browser.
Daniel Sandler [Fri, 28 Aug 2009 18:51:55 +0000 (14:51 -0400)]
High-resolution (hdpi) artwork from TAT for Browser.
Android (Google) Code Review [Fri, 28 Aug 2009 18:15:06 +0000 (11:15 -0700)]
Merge change 23104 into eclair
* changes:
Improve the appearance of the minitabs on the landing page.
Leon Scroggins [Fri, 28 Aug 2009 15:44:12 +0000 (11:44 -0400)]
Improve the appearance of the minitabs on the landing page.
Use the default look, but modified to be shorter in height.
Change-Id: Ib0b8a6ab4ce0a809504d92a2b40ac39224264626
Eric Fischer [Fri, 28 Aug 2009 00:23:43 +0000 (17:23 -0700)]
Armor string format tokens with translation placeholders.
Change-Id: Ia5b9e9f58cc8355b3d5d522afc3f02d6ff0d2b0e
Grace Kloba [Thu, 27 Aug 2009 21:40:32 +0000 (14:40 -0700)]
am
b8a9cb0e: Fix the activity leak in the Browser.
Merge commit '
b8a9cb0e2b3b2a1bb250853a79b8ea2046ff3d6e' into eclair
* commit '
b8a9cb0e2b3b2a1bb250853a79b8ea2046ff3d6e':
Fix the activity leak in the Browser.
Grace Kloba [Thu, 27 Aug 2009 18:53:36 +0000 (11:53 -0700)]
Fix the activity leak in the Browser.
The IconListenerSet inside CombinedBookmarkHistoryActivity is static. So when
the activity is destroyed, it needs to remove its listener to avoid leak.
Ben Murdoch [Tue, 25 Aug 2009 18:38:07 +0000 (19:38 +0100)]
Use the estimated size of new databases as the default quota if we have enough space to satisfy it.
Change-Id:I23daac8fbf27f50f304ee53060353423deaed50a
Leon Scroggins [Wed, 19 Aug 2009 20:26:12 +0000 (16:26 -0400)]
Implement new title bar behavior.
Depends on a change to frameworks/base. When loading a new page,
display the title bar. Implement a callback so that we can toggle
the title bar's visibility on mobile sites.
Change-Id: Ie2cbe2a53bcfd1bcc9fb9d2f12285ecf45e06997
Steve Block [Fri, 21 Aug 2009 12:16:58 +0000 (13:16 +0100)]
Browser-side changes to persist Geolocation permissions between browser sessions.
This fixes bug http://b/issue?id=
2054365.
Steve Block [Fri, 21 Aug 2009 11:54:47 +0000 (12:54 +0100)]
Removes unnecessary syncing of databse and app cache paths with browser settings XML.
These paths are not stored in the XML, so syncing is not required.
This code is probably a legacy from when there were plans to include the paths in the browser settings and hence the XML.
Android (Google) Code Review [Mon, 24 Aug 2009 10:09:36 +0000 (03:09 -0700)]
Merge change 22261 into eclair
* changes:
Adds browser-side of logic to make Geolocation obey Browser 'Enable Location' setting.
Android (Google) Code Review [Mon, 24 Aug 2009 09:29:43 +0000 (02:29 -0700)]
Merge change 22080 into eclair
* changes:
Fixes a bug in the browser settings menu. Correctly hooks up 'Clear location access'.
Leon Scroggins [Fri, 21 Aug 2009 15:58:28 +0000 (11:58 -0400)]
Improve the look of the search bar on the landing page.
Use the actual look as defined in search_bar.xml. Fixes:
http://b/issue?id=
2042059
http://b/issue?id=
2042041
Steve Block [Fri, 21 Aug 2009 09:26:25 +0000 (10:26 +0100)]
Adds browser-side of logic to make Geolocation obey Browser 'Enable Location' setting.
This fixes bug http://b/issue?id=
2067559.
Steve Block [Thu, 20 Aug 2009 17:11:08 +0000 (18:11 +0100)]
Fixes a bug in the browser settings menu. Correctly hooks up 'Clear location access'.
Android (Google) Code Review [Wed, 19 Aug 2009 19:43:28 +0000 (12:43 -0700)]
Merge change 21933 into eclair
* changes:
Fix a bug where we were opening a new tab unnecessarily.
Leon Scroggins [Wed, 19 Aug 2009 19:31:58 +0000 (15:31 -0400)]
Fix a bug where we were opening a new tab unnecessarily.
Code got changed along with other code. When changing to an appTab,
if it matches the current tab, do nothing. Fixes
http:/b/issue?id=197317
Leon Scroggins [Tue, 18 Aug 2009 18:13:31 +0000 (14:13 -0400)]
Fix a crasher on the most visited page when the history is empty.
Make sure that the empty view is always available by setting it
as the content view, and adding the list or grid. Fixes
http://b/issue?id=
2041975
Android (Google) Code Review [Wed, 19 Aug 2009 16:06:15 +0000 (09:06 -0700)]
Merge change 21887 into eclair
* changes:
Fix a crash.
Leon Scroggins [Wed, 19 Aug 2009 15:25:14 +0000 (11:25 -0400)]
Fix a crash.
When the bookmarks page is opened to create a shortcut, there is
no menu. So do not modify it.
Leon Scroggins [Tue, 18 Aug 2009 23:47:09 +0000 (19:47 -0400)]
Allow user to enter a URL to visit a site without closing the browser.
Eric Fischer [Tue, 18 Aug 2009 18:00:22 +0000 (11:00 -0700)]
am
9f0d27c8: (-s ours) Import revised translations. DO NOT MERGE
Merge commit '
9f0d27c82baa6d838147afabdf6f0764bf265a21' into eclair
* commit '
9f0d27c82baa6d838147afabdf6f0764bf265a21':
Import revised translations. DO NOT MERGE
Grace Kloba [Tue, 18 Aug 2009 15:42:32 +0000 (08:42 -0700)]
resolved conflicts for merge of
918e1d78 to eclair
Leon Scroggins [Tue, 18 Aug 2009 14:22:05 +0000 (10:22 -0400)]
Ensure that switching tabs also updates the title bar.
In particular, when we open a tab associated with an appId, move
the title bar to that tab's title.
Leon Scroggins [Mon, 17 Aug 2009 21:01:38 +0000 (17:01 -0400)]
Disable "open in new window" if Go came up from a new tab.
Eric Fischer [Mon, 17 Aug 2009 20:14:08 +0000 (13:14 -0700)]
Import revised translations. DO NOT MERGE
Leon Scroggins [Fri, 14 Aug 2009 22:28:01 +0000 (18:28 -0400)]
Fix several bugs surrounding the "go" screen and closing tabs.
http://b/issue?id=
2053635 : Home page should appear when last tab is closed
http://b/issue?id=
2049620 : click on a link opening a new window should skip the landing page
http://b/issue?id=
2042079 : When I open a new tab, then hit back get strange state
Now if you close the last tab, it will bring up the "go" screen.
If you hit back, it closes the browser; otherwise it will go where
the user specifies. When opening a new tab, if the user hits
back, it will close this new tab. This also prevents the "go"
screen from coming up unnecessarily when a link opens in a new
window.
Leon Scroggins [Mon, 17 Aug 2009 16:04:20 +0000 (12:04 -0400)]
Bring up search directly from the Go page.
Rather than returning to BrowserActivity to bring up search, bring
it up directly from the Go page. This means that hitting back from
search will take you to the Go page (if you reached search from
the Go page). Fixes http://b/issue?id=
2042017
Leon Scroggins [Fri, 14 Aug 2009 20:32:43 +0000 (16:32 -0400)]
Prevent opening the keyboard from changing the tab.
Leon Scroggins [Fri, 7 Aug 2009 20:12:57 +0000 (16:12 -0400)]
Hide the title bar when zoomed in
Patrick Scott [Fri, 14 Aug 2009 17:35:53 +0000 (13:35 -0400)]
Set the new tab as the current tab to reflect the old behavior.
Android (Google) Code Review [Fri, 14 Aug 2009 18:30:10 +0000 (11:30 -0700)]
Merge change 21291 into eclair
* changes:
Bring up the "Go" page when touching the title bar.
Android (Google) Code Review [Fri, 14 Aug 2009 18:24:37 +0000 (11:24 -0700)]
Merge change 21296 into eclair
* changes:
Fix a class cast exception.
Leon Scroggins [Fri, 14 Aug 2009 18:16:10 +0000 (14:16 -0400)]
Fix a class cast exception.
If we are in grid mode, the target view will not be
a history item. Find out the information using the
BookmarksAdapter instead.
Leon Scroggins [Fri, 14 Aug 2009 18:12:47 +0000 (14:12 -0400)]
Use the correct resource for the add bookmark item in the menu.
Leon Scroggins [Fri, 14 Aug 2009 17:39:05 +0000 (13:39 -0400)]
Bring up the "Go" page when touching the title bar.
Grace Kloba [Thu, 13 Aug 2009 21:55:06 +0000 (14:55 -0700)]
Fix b/issue?id=
2052775. According to the comment, we try to call
pauseWebView(). But as mActivityInPause is false, pauseWebView doesn't do
anything. This cause inbalanced pause/resume and the WebCoreThread's timer
is never put on hold even Browser is in the background.
Christopher Tate [Thu, 13 Aug 2009 21:19:10 +0000 (14:19 -0700)]
Add BACKUP_DATA permission to the browser
Cary Clark [Wed, 12 Aug 2009 16:56:42 +0000 (12:56 -0400)]
handle false results in file.delete and similar calls
found by findbugs
http://b/issue?id=
1856614
Leon Scroggins [Mon, 10 Aug 2009 21:36:42 +0000 (17:36 -0400)]
Initial attempt to get the sliding title bar working, using a Gallery.
In addition the sliding title bar, I have now removed the TabPicker.
Now, when changing to a new tab, we just go straight there. Also
put back in Add bookmark in the top level menu. And fix the bug
where switching tabs was always bringing up the bookmarks.
Andrei Popescu [Wed, 12 Aug 2009 18:35:50 +0000 (19:35 +0100)]
remove gears
Ramanan Rajeswaran [Wed, 12 Aug 2009 22:18:36 +0000 (15:18 -0700)]
Merge commit '
60c8c06e' into manualmerge
Ramanan Rajeswaran [Wed, 12 Aug 2009 21:35:44 +0000 (14:35 -0700)]
Change the default google homepage to google.co.jp
Patrick Scott [Wed, 12 Aug 2009 13:15:51 +0000 (09:15 -0400)]
Pass unhandled keys up to the main tab.
Grace Kloba [Wed, 12 Aug 2009 16:35:42 +0000 (09:35 -0700)]
Change the Browser trace file from data dir to sdcard, increase the size
from 8M to 20M so that common sites like nytimes.com can fit.
Cary Clark [Tue, 11 Aug 2009 21:40:45 +0000 (17:40 -0400)]
close streams when done
found by findbugs
http://b/issue?id=
1856630
Cary Clark [Tue, 11 Aug 2009 20:42:26 +0000 (16:42 -0400)]
make private inner classes static
bug found by findbugs
http://b/issue?id=
1856695
Cary Clark [Tue, 11 Aug 2009 18:49:51 +0000 (14:49 -0400)]
remove unused locals
found by findbugs
http://b/issue?id=
1856758
Android (Google) Code Review [Tue, 11 Aug 2009 18:41:58 +0000 (11:41 -0700)]
Merge change 20761
* changes:
make finals static, remove unused local
Cary Clark [Tue, 11 Aug 2009 18:19:06 +0000 (14:19 -0400)]
make finals static, remove unused local
found by findbugs
http://b/issue?id=
1856725
http://b/issue?id=
1856786
Cary Clark [Tue, 11 Aug 2009 18:04:49 +0000 (14:04 -0400)]
remove unused variable
found by findbugs
http://b/issue?id=
1856781