OSDN Git Service

amdgpu: Use uint32_t i in amdgpu_find_bo_by_cpu_mapping
authorMichel Dänzer <michel.daenzer@amd.com>
Tue, 14 Aug 2018 09:41:29 +0000 (11:41 +0200)
committerMichel Dänzer <michel@daenzer.net>
Wed, 15 Aug 2018 08:34:59 +0000 (10:34 +0200)
The compiler points out that an int doesn't work as intended if
dev->bo_handles.max_key > INT_MAX:

../../amdgpu/amdgpu_bo.c: In function ‘amdgpu_find_bo_by_cpu_mapping’:
../../amdgpu/amdgpu_bo.c:550:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
  for (i = 0; i < dev->bo_handles.max_key; i++) {
                ^
../../amdgpu/amdgpu_bo.c:558:8: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
  if (i < dev->bo_handles.max_key) {
        ^

Fixes: 4d454424e1f2 ("amdgpu: add a function to find bo by cpu mapping
                     (v2)")
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
amdgpu/amdgpu_bo.c

index b790e9b..86d1c14 100644 (file)
@@ -535,7 +535,7 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
                                  amdgpu_bo_handle *buf_handle,
                                  uint64_t *offset_in_bo)
 {
-       int i;
+       uint32_t i;
        struct amdgpu_bo *bo;
 
        if (cpu == NULL || size == 0)