OSDN Git Service

Fix one warning (v2)
authorJammy Zhou <Jammy.Zhou@amd.com>
Mon, 27 Apr 2015 02:29:55 +0000 (10:29 +0800)
committerEmil Velikov <emil.l.velikov@gmail.com>
Thu, 28 May 2015 14:49:18 +0000 (15:49 +0100)
xf86drm.c:356:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
  group = (serv_group >= 0) ? serv_group : DRM_DEV_GID;
  ^

v2: do 'int' cast to fix the warning

Signed-off-by: Jammy Zhou <Jammy.Zhou@amd.com>
Reviewed-by: Jan Vesely <jan.vesely@rutgers.edu>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
xf86drm.c

index 2245f99..0a66a4a 100644 (file)
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -349,7 +349,7 @@ static int drmOpenDevice(dev_t dev, int minor, int type)
     }
 
     if (drm_server_info) {
-       group = (serv_group >= 0) ? serv_group : DRM_DEV_GID;
+       group = ((int)serv_group >= 0) ? serv_group : DRM_DEV_GID;
        chown_check_return(buf, user, group);
        chmod(buf, devmode);
     }