exynos/fimg2d: remove default case from g2d_get_blend_op()

We now validate the blending mode via g2d_validate_mode()
prior to feeding it to g2d_get_blend_op().

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
index 9d9359a..d7cbb24 100644 (file)
--- a/exynos/exynos_fimg2d.c
+++ b/exynos/exynos_fimg2d.c
@@ -64,6 +64,11 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op)
 
        val.val = 0;
 
+       /*
+        * The switch statement is missing the default branch since
+        * we assume that the caller checks the blending operation
+        * via g2d_validate_blending_op() first.
+        */
        switch (op) {
        case G2D_OP_CLEAR:
        case G2D_OP_DISJOINT_CLEAR:
@@ -91,11 +96,6 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op)
                SET_BF(val, G2D_COEFF_MODE_SRC_ALPHA, 0, 0, 0,
                                G2D_COEFF_MODE_SRC_ALPHA, 1, 0, 0);
                break;
-       default:
-               fprintf(stderr, "Not support operation(%d).\n", op);
-               SET_BF(val, G2D_COEFF_MODE_ONE, 0, 0, 0, G2D_COEFF_MODE_ZERO,
-                               0, 0, 0);
-               break;
        }
 
        return val.val;