OSDN Git Service

amdgpu: Eliminate void* arithmetic in amdgpu_find_bo_by_cpu_mapping
authorMichel Dänzer <michel.daenzer@amd.com>
Tue, 14 Aug 2018 09:53:19 +0000 (11:53 +0200)
committerMichel Dänzer <michel@daenzer.net>
Fri, 17 Aug 2018 07:12:42 +0000 (09:12 +0200)
Arithmetic using void* pointers isn't defined by the C standard, only as
a GCC extension. Avoids compiler warnings:

../../amdgpu/amdgpu_bo.c: In function ‘amdgpu_find_bo_by_cpu_mapping’:
../../amdgpu/amdgpu_bo.c:554:48: warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]
   if (cpu >= bo->cpu_ptr && cpu < (bo->cpu_ptr + bo->alloc_size))
                                                ^
../../amdgpu/amdgpu_bo.c:561:23: warning: pointer of type ‘void *’ used in subtraction [-Wpointer-arith]
   *offset_in_bo = cpu - bo->cpu_ptr;
                       ^

v2: Use uintptr_t instead of char*, don't change function signature
    (Junwei Zhang)

Fixes: 4d454424e1f2 ("amdgpu: add a function to find bo by cpu mapping
                     (v2)")
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Junwei Zhang <Jerry.Zhang@amd.com>
amdgpu/amdgpu_bo.c

index 86d1c14..8efd014 100644 (file)
@@ -551,14 +551,15 @@ int amdgpu_find_bo_by_cpu_mapping(amdgpu_device_handle dev,
                bo = handle_table_lookup(&dev->bo_handles, i);
                if (!bo || !bo->cpu_ptr || size > bo->alloc_size)
                        continue;
-               if (cpu >= bo->cpu_ptr && cpu < (bo->cpu_ptr + bo->alloc_size))
+               if (cpu >= bo->cpu_ptr &&
+                   cpu < (void*)((uintptr_t)bo->cpu_ptr + bo->alloc_size))
                        break;
        }
 
        if (i < dev->bo_handles.max_key) {
                atomic_inc(&bo->refcount);
                *buf_handle = bo;
-               *offset_in_bo = cpu - bo->cpu_ptr;
+               *offset_in_bo = (uintptr_t)cpu - (uintptr_t)bo->cpu_ptr;
        } else {
                *buf_handle = NULL;
                *offset_in_bo = 0;