OSDN Git Service

meson: require valgrind 3.10.0 to enable it with freedreno
authorJose Maria Casanova Crespo <jmcasanova@igalia.com>
Tue, 5 May 2020 19:50:33 +0000 (21:50 +0200)
committerJosé Casanova Crespo <jmcasanova@igalia.com>
Thu, 7 May 2020 02:57:55 +0000 (02:57 +0000)
Freedreno uses VALGRIND_ENABLE_ADDR_ERROR_REPORTING_IN_RANGE that was
introduced in Valgrind 3.10.0

Raspbian Buster includes Valgrind 3.7.0, so when valgrind is installed
as freedreno is build by default the build becomes broken. So lets
require 3.10 to enable valgrind when freedreno is built.

v2: Keep the arguments listed in the same order (Emil Velikov)

Closes: https://gitlab.freedesktop.org/mesa/drm/-/issues/37
Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
meson.build

index 461fefe..a7c5476 100644 (file)
@@ -249,7 +249,11 @@ else
 endif
 _valgrind = get_option('valgrind')
 if _valgrind != 'false'
-  dep_valgrind = dependency('valgrind', required : _valgrind == 'true')
+  if with_freedreno
+    dep_valgrind = dependency('valgrind', required : _valgrind == 'true', version : '>=3.10.0')
+  else
+    dep_valgrind = dependency('valgrind', required : _valgrind == 'true')
+  endif
   with_valgrind = dep_valgrind.found()
 else
   dep_valgrind = []