OSDN Git Service

minigbm: constify and staticify functions/structs
authorStéphane Marchesin <marcheu@chromium.org>
Fri, 26 Feb 2016 21:36:22 +0000 (13:36 -0800)
committerchrome-bot <chrome-bot@chromium.org>
Mon, 29 Feb 2016 22:19:28 +0000 (14:19 -0800)
A lot of these can be made const/static so let's do this.

BUG=none
TEST=compiles

Change-Id: Id0b534ca477b25488b264622f062471063378c1c
Signed-off-by: Stphane Marchesin <marcheu@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/329561
Commit-Ready: Stéphane Marchesin <marcheu@chromium.org>
Tested-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
cirrus.c
exynos.c
gma500.c
i915.c
marvell.c
mediatek.c
rockchip.c
tegra.c

index 3f2f7ba..639233e 100644 (file)
--- a/cirrus.c
+++ b/cirrus.c
@@ -7,7 +7,7 @@
 #include "gbm_priv.h"
 #include "helpers.h"
 
-struct gbm_driver gbm_driver_cirrus =
+const struct gbm_driver gbm_driver_cirrus =
 {
        .name = "cirrus",
        .bo_create = gbm_dumb_bo_create,
index ba960fd..c2eb59b 100644 (file)
--- a/exynos.c
+++ b/exynos.c
@@ -17,8 +17,9 @@
 #include "helpers.h"
 #include "util.h"
 
-int gbm_exynos_bo_create(struct gbm_bo *bo, uint32_t width, uint32_t height,
-                        uint32_t format, uint32_t flags)
+static int gbm_exynos_bo_create(struct gbm_bo *bo,
+                               uint32_t width, uint32_t height,
+                               uint32_t format, uint32_t flags)
 {
        size_t plane;
 
index 95d663c..4e84bac 100644 (file)
--- a/gma500.c
+++ b/gma500.c
@@ -7,7 +7,7 @@
 #include "gbm_priv.h"
 #include "helpers.h"
 
-struct gbm_driver gbm_driver_gma500 =
+const struct gbm_driver gbm_driver_gma500 =
 {
        .name = "gma500",
        .bo_create = gbm_dumb_bo_create,
diff --git a/i915.c b/i915.c
index 6616a54..c152b0c 100644 (file)
--- a/i915.c
+++ b/i915.c
@@ -35,7 +35,7 @@ static int get_gen(int device_id)
        return 4;
 }
 
-int gbm_i915_init(struct gbm_device *gbm)
+static int gbm_i915_init(struct gbm_device *gbm)
 {
        struct gbm_i915_device *i915_gbm;
        drm_i915_getparam_t get_param;
@@ -63,7 +63,7 @@ int gbm_i915_init(struct gbm_device *gbm)
        return 0;
 }
 
-void gbm_i915_close(struct gbm_device *gbm)
+static void gbm_i915_close(struct gbm_device *gbm)
 {
        free(gbm->priv);
        gbm->priv = NULL;
@@ -119,8 +119,9 @@ static int i915_verify_dimensions(struct gbm_device *gbm, uint32_t stride,
        return 1;
 }
 
-int gbm_i915_bo_create(struct gbm_bo *bo, uint32_t width, uint32_t height,
-                      uint32_t format, uint32_t flags)
+static int gbm_i915_bo_create(struct gbm_bo *bo,
+                             uint32_t width, uint32_t height,
+                             uint32_t format, uint32_t flags)
 {
        struct gbm_device *gbm = bo->gbm;
        int bpp = gbm_stride_from_format(format, 1);
index 6a5b442..866e957 100644 (file)
--- a/marvell.c
+++ b/marvell.c
@@ -9,7 +9,7 @@
 #include "gbm_priv.h"
 #include "helpers.h"
 
-struct gbm_driver gbm_driver_marvell =
+const struct gbm_driver gbm_driver_marvell =
 {
        .name = "marvell",
        .bo_create = gbm_dumb_bo_create,
index cfc166a..3ef05e8 100644 (file)
@@ -14,8 +14,9 @@
 #include "gbm_priv.h"
 #include "helpers.h"
 
-int gbm_mediatek_bo_create(struct gbm_bo *bo, uint32_t width, uint32_t height,
-                          uint32_t format, uint32_t flags)
+static int gbm_mediatek_bo_create(struct gbm_bo *bo,
+                                 uint32_t width, uint32_t height,
+                                 uint32_t format, uint32_t flags)
 {
        size_t size;
        struct drm_mtk_gem_create gem_create;
@@ -41,7 +42,7 @@ int gbm_mediatek_bo_create(struct gbm_bo *bo, uint32_t width, uint32_t height,
        return 0;
 }
 
-struct gbm_driver gbm_driver_mediatek =
+const struct gbm_driver gbm_driver_mediatek =
 {
        .name = "mediatek",
        .bo_create = gbm_mediatek_bo_create,
index e43c760..4deb902 100644 (file)
@@ -14,8 +14,9 @@
 #include "gbm_priv.h"
 #include "helpers.h"
 
-int gbm_rockchip_bo_create(struct gbm_bo *bo, uint32_t width, uint32_t height,
-                          uint32_t format, uint32_t flags)
+static int gbm_rockchip_bo_create(struct gbm_bo *bo,
+                                 uint32_t width, uint32_t height,
+                                 uint32_t format, uint32_t flags)
 {
        size_t size;
        struct drm_rockchip_gem_create gem_create;
@@ -41,7 +42,7 @@ int gbm_rockchip_bo_create(struct gbm_bo *bo, uint32_t width, uint32_t height,
        return 0;
 }
 
-struct gbm_driver gbm_driver_rockchip =
+const struct gbm_driver gbm_driver_rockchip =
 {
        .name = "rockchip",
        .bo_create = gbm_rockchip_bo_create,
diff --git a/tegra.c b/tegra.c
index 6e9cba1..33ab82e 100644 (file)
--- a/tegra.c
+++ b/tegra.c
@@ -148,7 +148,7 @@ static int gbm_tegra_bo_create(struct gbm_bo *bo, uint32_t width,
        return 0;
 }
 
-struct gbm_driver gbm_driver_tegra =
+const struct gbm_driver gbm_driver_tegra =
 {
        .name = "tegra",
        .bo_create = gbm_tegra_bo_create,