make sem_wait and sem_timedwait interruptible by signals

this reverts commit c0ed5a201b2bdb6d1896064bec0020c9973db0a1, which
was based on a mistaken reading of POSIX due to inconsistency between
the description (which requires return upon interruption by a signal)
and the errors list (which wrongly lists EINTR as "may fail").

since the previously-introduced behavior was a workaround for an old
kernel bug to ensure safety of correct programs that were not hardened
against the bug, an effort has been made to preserve it for programs
which do not use interrupting signal handlers. the stage for this was
set in commit a63c0104e496f7ba78b64be3cd299b41e8cd427f, which makes
the futex __timedwait backend suppress EINTR if it's seen when no
interrupting signal handlers have been installed.

based loosely on a patch submitted by Orivej Desh, but with
unnecessary additional changes removed.

diff --git a/src/thread/sem_timedwait.c b/src/thread/sem_timedwait.c
index 8132eb1..58d3ebf 100644 (file)
--- a/src/thread/sem_timedwait.c
+++ b/src/thread/sem_timedwait.c
@@ -22,7 +22,7 @@ int sem_timedwait(sem_t *restrict sem, const struct timespec *restrict at)
                pthread_cleanup_push(cleanup, (void *)(sem->__val+1));
                r = __timedwait_cp(sem->__val, -1, CLOCK_REALTIME, at, sem->__val[2]);
                pthread_cleanup_pop(1);
-               if (r && r != EINTR) {
+               if (r) {
                        errno = r;
                        return -1;
                }