omx: fix another memory leak

The 'strdup' call in createSoftOMXComponent() is never freed.

diff --git a/omx/SoftFFmpegAudio.cpp b/omx/SoftFFmpegAudio.cpp
index 887620f..d1d27dd 100644 (file)
--- a/omx/SoftFFmpegAudio.cpp
+++ b/omx/SoftFFmpegAudio.cpp
@@ -1576,12 +1576,12 @@ SoftOMXComponent* SoftFFmpegAudio::createSoftOMXComponent(
         const char *name, const OMX_CALLBACKTYPE *callbacks,
         OMX_PTR appData, OMX_COMPONENTTYPE **component) {
     OMX_AUDIO_CODINGTYPE codingType = OMX_AUDIO_CodingAutoDetect;
-    char *componentRole = NULL;
+    const char *componentRole = NULL;
     enum AVCodecID codecID = AV_CODEC_ID_NONE;
 
     for (size_t i = 0; i < kNumAudioComponents; ++i) {
         if (!strcasecmp(name, kAudioComponents[i].mName)) {
-            componentRole = strdup(kAudioComponents[i].mRole);
+            componentRole = kAudioComponents[i].mRole;
             codingType = kAudioComponents[i].mAudioCodingType;
             codecID = kAudioComponents[i].mCodecID;
             break;

diff --git a/omx/SoftFFmpegVideo.cpp b/omx/SoftFFmpegVideo.cpp
index 48afb49..ae1f1ae 100644 (file)
--- a/omx/SoftFFmpegVideo.cpp
+++ b/omx/SoftFFmpegVideo.cpp
@@ -836,12 +836,12 @@ SoftOMXComponent* SoftFFmpegVideo::createSoftOMXComponent(
         return NULL;
 
     OMX_VIDEO_CODINGTYPE codingType = OMX_VIDEO_CodingAutoDetect;
-    char *componentRole = NULL;
+    const char *componentRole = NULL;
     enum AVCodecID codecID = AV_CODEC_ID_NONE;
 
     for (size_t i = 0; i < kNumVideoComponents; ++i) {
         if (!strcasecmp(name, kVideoComponents[i].mName)) {
-            componentRole = strdup(kVideoComponents[i].mRole);
+            componentRole = kVideoComponents[i].mRole;
             codingType = kVideoComponents[i].mVideoCodingType;
             codecID = kVideoComponents[i].mCodecID;
             break;