OSDN Git Service
Nicolas Capens [Tue, 26 Mar 2019 15:43:57 +0000 (11:43 -0400)]
Add missing LLVM 7.0 source files
Fixes linking for MSVC build.
Bug b/
115344057
Change-Id: I9a38d987f0cf8c20c670ccdb1c38dd49681bb941
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27968
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Nicolas Capens [Tue, 26 Mar 2019 19:11:18 +0000 (15:11 -0400)]
Rename swiftshader_icd.def to libvk_swiftshader.def
The CMake build derives the .def name from the project name, which is
libvk_swiftshader.
Bug b/
115344057
Bug b/
116336664
Change-Id: I236839b2da4531e01f5260705c189d9ae8df9769
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27988
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Ben Clayton [Wed, 27 Mar 2019 16:10:43 +0000 (16:10 +0000)]
.gitignore: .vscode/settings.json & .vscode/launch.json
This is per-user data and can easily contain paths to directories outside of the project.
Also remove .vscode/launch.json.
Change-Id: Iefedc52ec8446d4b6de5e6026761359ac9ac1a0f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28069
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Tue, 2 Apr 2019 16:05:40 +0000 (12:05 -0400)]
Fix materialization of function arguments
Subzero does not appear to preserve function arguments passed in as
registers onto the stack by itself. Any scratch registers can get reused
for local variable register allocation.
This workaround simply materializes each concrete Reactor variable
constructed from an argument on definition. It does not ensure that
arguments turned into variables at a later point are properly preserved.
Also this solution does not centralize the materialization, making it
bug prone when new concrete Reactor types are implemented.
Bug b/
129757459
Change-Id: I1007ea0e7204d05e60203b2e896589a03fc515a9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28309
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
SwiftShader Regression Bot [Tue, 2 Apr 2019 06:21:54 +0000 (07:21 +0100)]
Regres: Update test lists @
459453a9
Change-Id: I3d7474e24faccf30a11a9c9bfdae69aa1ae918bf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28251
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Nicolas Capens [Wed, 27 Mar 2019 19:27:27 +0000 (15:27 -0400)]
Eliminate Intermediate::replace()
With Reactor variables now merely tracking the last assigned rvalue if
used within a single basic block, we can avoid the unsafe replace()
operation on SpirvShader::Intermediate.
This effectively reverts
https://swiftshader-review.googlesource.com/c/SwiftShader/+/27769
Bug b/
129356087
Bug b/
128527271
Change-Id: Ibfafc6960ac7e10b898ff8804752b928a7fc1988
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28109
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Nicolas Capens [Wed, 27 Mar 2019 18:46:07 +0000 (14:46 -0400)]
Elide single basic block variable materialization
Variables which are only used within a single basic block and don't
have their address taken, don't require allocating stack memory.
Instead they can track the latest rvalue that has been assigned to them.
Allocating stack memory is necessary for variables that are assigned to
in divergent basic blocks since there is no single rvalue to track after
the merge point (unless we inserted phi instructions, but that is
outside of the scope of this change).
Because Reactor can't look forward to check whether a variable will be
used in divergent basic blocks, we keep the set of variables that may
not have been materialized yet, meaning they have no stack address yet.
When a branch is encountered, they are all materialized.
Variables not yet materialized at a Return() are 'killed' to prevent
materializing afterwards, which would cause the terminator ret
instruction to not be the last instruction of the basic block.
Note that this change creates a dependency of the Nucleus
implementation on Variable, which is currently defined in a higher
layer in Reactor.hpp. Since Variable doesn't depend on anything else
in Reactor.hpp it could be made part of Nucleus, or an in-between
layer could be added.
Bug b/
129356087
Change-Id: Ie8c09e34c8befb9787a5c0bca7a20e770bcbf8d3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27928
Tested-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Nicolas Capens [Wed, 27 Mar 2019 18:45:34 +0000 (14:45 -0400)]
Avoid Array<> assignment
The Array<> assignment operator gets auto-generated, but is unsafe as it
overwrites the Variable address field.
Also delete the Variable assignment operator.
Bug b/
129356087
Change-Id: If6d5945f2a56f9a81bbc1491a524e3f17c1561da
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28088
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Nicolas Capens [Tue, 26 Mar 2019 21:18:57 +0000 (17:18 -0400)]
Implement missing Short8 assignment operators
Bug b/
129356087
Change-Id: Iab3325d74e783fd158b49ca8f6512641bf7f89ec
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28008
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Fri, 22 Feb 2019 15:45:21 +0000 (15:45 +0000)]
Common: Document sw::Resource
It took me quite a while to figure out what this class was doing.
Change-Id: I97ab2576e309ee6ca69dd741fd47a86d8cdc6313
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/25248
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Nicolas Capens [Sun, 31 Mar 2019 00:47:10 +0000 (00:47 +0000)]
Revert "Create a recursive version of MutexLock, and apply it to EGL."
This reverts commit
20b950a2520dfd30e84bd5e45153e6bce362752d.
Reason for revert: This is causing regressions in Chrome tests (https://chromium-review.googlesource.com/
1546268) as well as google3 presubmit tests (cl/
241036666). In both cases there's a timeout.
Bug: b/
124530765
Change-Id: I570c4df5db9557a1ba7e46b07ba425f63cfa6744
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28268
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Wed, 27 Feb 2019 23:58:35 +0000 (23:58 +0000)]
Reactor: Replace ArgI for std::tuple_element
C++ now provides this template magic so you don't have to.
Also remove Arg(Function<Return(Arguments...)> &) function that wasn't referenced and wouldn't compile if it were.
Bug: b/
126126820
Bug: b/
129403963
Change-Id: I939e4f7cb95c32b8e663df7da6211460c5de605f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/25749
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <headlessclayton@gmail.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Fri, 8 Mar 2019 08:23:34 +0000 (08:23 +0000)]
SpirvShader: Improve docs on IsStorageInterleavedByLane()
My previous attempt to document this wasn't great.
Reworked the text and diagram to better illustrate what's going on.
Still using 'interleaved-by-lane' terminology for now.
Bug: b/
126330097
Change-Id: Ia6031f06f9eab0f1f05d80151d9a89de5525b5eb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26529
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <headlessclayton@gmail.com>
SwiftShader Regression Bot [Sat, 30 Mar 2019 06:43:05 +0000 (06:43 +0000)]
Regres: Update test lists @
513ed1d5
Change-Id: I22da31a6704e8556c9b3ac03e4b71542b2993ecd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28250
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Ben Clayton [Thu, 28 Mar 2019 16:07:00 +0000 (16:07 +0000)]
SpirvShader: Fixes for complex loops.
Emit loops in forward direction. While traversing backwards from the loop back-edge means you don't have to worry about flowing down the merge block, it can lead to blocks being generated in orders that can break the visit-once logic.
Don't consider flows passing through the return block as a back edge.
Strip unreachable blocks from ins - nothing should ever consider them.
Tests: dEQP-VK.glsl.loops.*
Bug: b/
128527271
Change-Id: I497a06f5ce65d54b39294e4016b2df6d2c70487c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28188
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Tue, 26 Mar 2019 11:10:16 +0000 (11:10 +0000)]
SpirvShader: Handle dead code branches.
Given the following situation:
```
>->- alive >->->->
\
>-> alive
/
unreachable >->
```
We would attempt to codegen the dead block (all blocks ensure their in's are processed first).
However dEQP-VK.spirv_assembly.instruction.graphics.conditional_branch.same_labels_false_frag seems to have dead blocks that use values from blocks it couldn't possibly use (as it has no ins).
While this is probably just a broken test, it is still good to harden up the compiler to pathological cases like this.
Tests: dEQP-VK.spirv_assembly.instruction.compute.*
Tests: dEQP-VK.spirv_assembly.instruction.graphics.*
Bug: b/
128527271
Change-Id: Ibaacf6a58cf7ab6e73771b58cfe67f0c394e53c6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27948
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Cody Schuffelen [Sat, 16 Mar 2019 00:31:10 +0000 (17:31 -0700)]
Create a recursive version of MutexLock, and apply it to EGL.
This fixes one deadlock in Android's use of SwiftShader.
Bug: b/
124530765
Test: atest CtsGraphicsTestCases:android.graphics.cts.BitmapTest#testDrawingHardwareBitmapNotLeaking -- --abi x86
Signed-off-by: Cody Schuffelen <schuffelen@google.com>
Change-Id: I0a8a2674c94ae4fb8b3edb1a2b070b8b3568f8f2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27408
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Thu, 28 Mar 2019 17:15:04 +0000 (17:15 +0000)]
VkPipeline: Debug - show ids not names in disassembly.
Names are difficult to match against values in SpirvShader.
Change-Id: I313534c828b63bb73e8d72fa5475acfb93982bcd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28190
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Nicolas Capens [Fri, 29 Mar 2019 10:22:17 +0000 (06:22 -0400)]
Fix descriptor set allocation and update
- Descriptor set pool allocation did not take the layout pointer into
account.
- Allocating descriptor sets from the pool was not tracking the first
node.
- The pointer to a second allocation node was offset from null instead
of the pool base address.
- Added assert that the descriptor update type matches the layout.
- Refactoring to avoid duplicate casting of handles.
Bug b/
123244275
Tests: dEQP-VK.api.object_management.*
Change-Id: Idf7aeb8d2597b30038ba1e9e371d99f09639f13c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28230
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
SwiftShader Regression Bot [Fri, 29 Mar 2019 06:39:44 +0000 (06:39 +0000)]
Regres: Update test lists @
51562f15
Change-Id: Idc12be5aa3dc02ceec7eff3d148a730b9d5221f8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28248
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Fri, 29 Mar 2019 02:08:39 +0000 (19:08 -0700)]
Add support for OpMatrixTimesMatrix
Bug: b/
126873455
Test: dEQP-VK.glsl.matrix.*
Change-Id: I3070690017263b3bf766a329ef7729206f285e45
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28228
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Chris Forbes [Fri, 22 Mar 2019 21:47:47 +0000 (14:47 -0700)]
Wire up indirect dispatch
Bug: b/
118619338
Change-Id: Ia03cbc8908efcbb5264f9fbdc91f06eac964c396
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27908
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Wed, 27 Mar 2019 16:21:27 +0000 (16:21 +0000)]
Add .vscode/c_cpp_properties.json
This holds the project include paths and defines, used by the C++ intellisense engine.
Change-Id: Ib87220cd49a38901167283316d4b549717516a0b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28068
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Chris Forbes [Fri, 22 Mar 2019 21:34:44 +0000 (14:34 -0700)]
Claim support for multi draw indirect + base instance
Support for these features fell out of doing the indirect support
properly. They are optional in the Vulkan spec because of certain
hardware that can't source the base instance indirectly, or would
require the multi draw to be unrolled in the command buffer. We
have neither constraint.
Bug: b/
118619338
Test: dEQP-VK.draw.*
Change-Id: I92291acc06a3abc5f25ea2a2eea18634b3035a01
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27889
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Chris Forbes [Fri, 22 Mar 2019 21:12:50 +0000 (14:12 -0700)]
Implement indirect draws
Bug: b/
118619338
Test: dEQP-VK.draw.*
Change-Id: I282c0f1e8f44b0bec2318ab901ec511413bff11d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27888
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Chris Forbes [Wed, 27 Mar 2019 20:28:27 +0000 (09:28 +1300)]
Allow subpasses to use secondary command buffers
Bug: b/
118619338
Test: dEQP-VK.*secondary_cmd_buf*
Change-Id: I46e69e216ae4cc0a8e907692dfce270e11b690a2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28129
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Chris Forbes [Wed, 27 Mar 2019 21:32:55 +0000 (10:32 +1300)]
Add support for OpVectorTimesMatrix
Bug: b/
126873455
Test: dEQP-VK.glsl.matrix.mul.*
Change-Id: Ifbc224ad72c27a0168578565a2b50eae8a1088f7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28131
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Chris Forbes [Wed, 27 Mar 2019 20:53:20 +0000 (09:53 +1300)]
Add support for OpMatrixTimesVector
Bug: b/
126873455
Test: dEQP-VK.glsl.matrix.mul.*
Change-Id: I818ea43d952f8d6d6a2a569a18936277a69b2fab
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28130
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Alexis Hetu [Wed, 27 Mar 2019 19:09:51 +0000 (15:09 -0400)]
Proper mipmap size allocation for compressed textures
Bug b/
119620767
Change-Id: I2d0513ab4947e6794fb5122e625641ed1a7c84cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28108
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Alexis Hetu [Wed, 27 Mar 2019 15:33:15 +0000 (11:33 -0400)]
Add support for compressed image copy
Copying compressed images is just a matter of taking
block size into account and using a block as a single
unit of measure, instead of using a texel.
Bug b/
119620767
Tests: dEQP-VK.api.copy_and_blit.core.image_to_image.all_formats.color.*
Change-Id: Ie77defc197ac7abb09a8555b384093fd50be681b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28048
Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
SwiftShader Regression Bot [Thu, 28 Mar 2019 07:07:21 +0000 (07:07 +0000)]
Regres: Update test lists @
179c9324
Change-Id: I633d574918a18cf5d9e1a5945067553bf59d443e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28148
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Wed, 27 Mar 2019 20:16:20 +0000 (09:16 +1300)]
Add support for OpMatrixTimesScalar
For us this works identically to OpVectorTimesScalar.
Bug: b/
126873455
Test: dEQP-VK.glsl.matrix.mul.*
Change-Id: Ied8df4af108249a2f0d888d238db497209d01049
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28128
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Alistair Strachan [Wed, 27 Mar 2019 08:54:12 +0000 (17:54 +0900)]
Handle NULL 'value' to eglGetSyncAttribKHR()
The EGL spec does not specifically call out how to handle the case
where 'value' passed to eglGetSyncAttribKHR is NULL, however many
implementations will set the context error to EGL_BAD_PARAMETER
and return without crashing. dEQP has a test which specifically
checks for this behavior. Align SwiftShader's implementation with
other EGL implementations.
Bug: b/
74572503
Test: dEQP-EQL GetSyncInvalidValueTest
Change-Id: Ic893cd7073c12c463ded78042031df1bf85f6ce2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28028
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alistair Strachan <astrachan@google.com>
Chris Forbes [Fri, 22 Mar 2019 01:08:08 +0000 (18:08 -0700)]
Remove asserts blocking pipeline derivatives
* Implementations must ignore basePipelineIndex & basePipelineHandle
if VK_PIPELINE_CREATE_DERIVATIVE_BIT is not specified.
* We choose to ignore the pipeline derivative controls entirely.
This is consistent with other implementations.
* Also remove assert blocking pipeline construction for subpasses
other than 0. This works fine.
Test: dEQP-VK.pipeline.derivative.compute.*
Change-Id: Ia03508b33397c60a3de5caf8536f7d75058738f6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27828
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Nicolas Capens [Tue, 19 Mar 2019 04:16:20 +0000 (00:16 -0400)]
Add GLES unit tests to Kokoro Windows CI
This required disabling the popup dialog which waits for a debugger to
be attached. This is achieved by setting an environment variable:
SWIFTSHADER_DISABLE_DEBUGGER_WAIT_DIALOG=1
Bug b/
123360006
Change-Id: Ic1269fdae3088b08a85322cbc7e33a3bdd8292cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27548
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@google.com>
SwiftShader Regression Bot [Wed, 27 Mar 2019 06:37:48 +0000 (06:37 +0000)]
Regres: Update test lists @
e747b3c3
Change-Id: Ief5ca440d499e049a76564d09edcd924fa203aa9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27950
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Ben Clayton [Thu, 21 Mar 2019 19:35:15 +0000 (19:35 +0000)]
SpirvShader: Implement loops
Tests: dEQP-VK.spirv_assembly.instruction.compute.*
Tests: dEQP-VK.spirv_assembly.instruction.graphics.*
Bug: b/
128527271
Change-Id: Ib556737c88dad1e51f3482b218cd7b0a9787b5be
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27776
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Sat, 23 Mar 2019 01:25:35 +0000 (21:25 -0400)]
Regenerate Windows LLVM configs
Running 'python3 update.py windows' from 'third_party/llvm-7.0/scripts/'
Bug chromium:944811
Change-Id: I4cd1a51b2c50f775d3131d5c66b1d33350b8004b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27870
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Sat, 23 Mar 2019 02:01:22 +0000 (22:01 -0400)]
Regenerate Linux LLVM configs
Running 'python3 update.py linux' from 'third_party/llvm-7.0/scripts/'
Also includes common config changes for LLVM 7.0.1 release.
Bug chromium:944811
Change-Id: I22dadbe6024a0e46707361abc92630381de12ad6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27871
Tested-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Fri, 22 Mar 2019 19:13:07 +0000 (15:13 -0400)]
Add Windows support to LLVM config generation script
Windows doesn't support 'make', but CMake can build the generated files
using 'cmake --build'.
Also set host=x64 to ensure the 64-bit toolchain gets used, to avoid
LLVM linking issues.
Also define __i386__ and __x86_64__ macros.
Bug b/
115344057
Change-Id: Idc3f78560b50e67b81a2e7a2490e0e5f23e6cc9d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27809
Tested-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Fri, 22 Mar 2019 19:15:33 +0000 (15:15 -0400)]
Disable LLVM_ENABLE_THREADS in config generation script
Bug chromium:944811
Change-Id: Ic44bfa123b5c64e3cd38022645a9e37ae5a29168
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27810
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 18:57:23 +0000 (18:57 +0000)]
SpirvShader: Implement OpSwitch
Tests: dEQP-VK.spirv_assembly.instruction.compute.*
Tests: dEQP-VK.spirv_assembly.instruction.graphics.*
Bug: b/
128527271
Change-Id: I7ba31ca504a582a4d36d25ef2747fb1c1607bade
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27775
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 18:47:15 +0000 (18:47 +0000)]
SpirvShader: Implement OpBranchConditional, OpPhi, ...
... OpUnreachable and OpReturn.
Tests: dEQP-VK.spirv_assembly.instruction.compute.*
Tests: dEQP-VK.spirv_assembly.instruction.graphics.*
Bug: b/
128527271
Change-Id: Iec9af723c72c873df8cbdea7c0027e2f7fa25e70
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27774
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Alexis Hetu [Wed, 20 Mar 2019 18:37:16 +0000 (14:37 -0400)]
Renderpass multisampling resolve
According to the Vulkan spec:
"If pResolveAttachments is not NULL, each of its elements
corresponds to a color attachment (the element in
pColorAttachments at the same index), and a multisample
resolve operation is defined for each attachment. At the
end of each subpass, multisample resolve operations read
the subpass’s color attachments, and resolve the samples
for each pixel to the same pixel location in the
corresponding resolve attachments, unless the resolve
attachment index is VK_ATTACHMENT_UNUSED."
Note: This cl adds support for multisampling, but
requires syncing before performing the resolve
operation. The intent is for the next cl to move
the resolve to Renderer::finishRendering(), in
order to avoid having to sync when it's not
necessary.
Bug b/
119620965
Change-Id: Id4fae41347e354b822d089fb5b6d4e36592c146b
Tests: dEQP-VK.pipeline.multisample.raster_samples.*
Tests: dEQP-VK.pipeline.multisample.raster_samples_consistency.*
Tests: dEQP-VK.pipeline.multisample.sample_mask.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27650
Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Alexis Hetu [Mon, 25 Mar 2019 14:24:23 +0000 (10:24 -0400)]
Fill buffer fix
memset was erroneously being used to copy 4 bytes at a time,
but the integer input value in memset is used as an 8 bit value,
so the fill was failing if the 4 bytes were not identical.
Tests: dEQP-VK.api.fill_and_update_buffer.*
Tests: dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.*
Bug b/
118383648
Change-Id: I29cb5915ebd3773b4afbd89850c47a042fff6952
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27872
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 17:46:08 +0000 (17:46 +0000)]
SpirvShader: Add EmitState
As we implement more complex control flow, we need to emit blocks with different active lane masks, and have finer control over block generation.
Bug: b/
128527271
Change-Id: Ica51bbea196b87ab442b394f0915e9a2cd375ac0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27770
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Thu, 21 Mar 2019 17:54:06 +0000 (17:54 +0000)]
SpirvShader: Add Intermediate::replace()
This lets us use Intermediate for building intermediates in loops without the need of an alloca.
Bug: b/
128527271
Change-Id: Id36db83d0b1cedd7700bbf2431eed9b4a03a7997
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27769
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 17:21:06 +0000 (17:21 +0000)]
SpirvShader: Add flow control info to Block.
Bug: b/
128527271
Change-Id: Ib66c32ba66bcb322be6fa72f01f6c8b1b4b90f0a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27768
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
SwiftShader Regression Bot [Tue, 26 Mar 2019 05:49:01 +0000 (05:49 +0000)]
Regres: Update test lists @
221459f4
Change-Id: If4da733b58f118698a84552ee3c9445203837767
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27786
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Sat, 9 Mar 2019 02:17:35 +0000 (18:17 -0800)]
Support for per-instance attributes
Bug: b/
129149966
Test: dEQP-VK.*instance*
Change-Id: I51642d32a8390495f5d9ecd0bb64bca1db33a03d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26689
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Ben Clayton [Mon, 25 Mar 2019 15:14:45 +0000 (15:14 +0000)]
Work around another MSVC bug with variadic macros.
Bug: b/
129259232
Change-Id: I095618a97edd5d4e8e28b90dd8f329b140aaa248
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27785
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Alexis Hetu [Thu, 21 Mar 2019 22:04:29 +0000 (18:04 -0400)]
Fixed erroneous filtering
Even if all the coordinates are within the bounds, if filtering is
enabled and the coordinates are closer to the edge than the center
of the pixel, we have to enable clamping to the edge so that the
samples used for filtering don't get invalid/negative factors.
Bug b/
119620767 b/
129258757
Change-Id: I0ba50fff2c2873e4a852e34878883c2e707d9886
Tests: dEQP-VK.api.copy_and_blit.core.blit_image.simple_tests.scaling_whole2.*
Tests: dEQP-VK.api.copy_and_blit.dedicated_allocation.blit_image.simple_tests.scaling_whole2.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27808
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
SwiftShader Regression Bot [Mon, 25 Mar 2019 05:49:53 +0000 (05:49 +0000)]
Regres: Update test lists @
e276f52b
Change-Id: Ie7796ec30e26be45a7b4c4233913c2ad94549b6d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27781
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Thu, 21 Mar 2019 21:14:40 +0000 (14:14 -0700)]
Remove extra stencil state from DrawData
In both the classic and pastel backends, we accidentally had *3* sets of
stencil state in the draw data. The generated routines use the array
only -- the separate stencilCCW variable is never touched.
Change-Id: I7898641bc8dbf387335528da3729e30d28b996aa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27790
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Nicolas Capens [Fri, 22 Mar 2019 18:55:46 +0000 (14:55 -0400)]
Remove top-level kokoro/ folder
We now use tests/kokoro/ instead.
Bug b/
126742833
Change-Id: I50e41a6299238ca91ff92c0947b3060f9a840a5d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27789
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Nico Weber [Fri, 22 Mar 2019 13:15:16 +0000 (09:15 -0400)]
Build LLVM with threads disabled.
As far as I can tell, swiftshader doesn't use LLVM's threading capabilities
for anything, and disabling them sidesteps an issue with libc++/win -- so
turn them off.
Bug: chromium:944811
Change-Id: Idf7eee5aa4693e9d2dcb744638ad9de53f714173
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27849
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nico Weber <thakis@chromium.org>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Thu, 21 Mar 2019 17:23:50 +0000 (13:23 -0400)]
Implement atomic load/store memory ordering
Bug b/
127472316
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.load
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.store
Change-Id: I0379a1a74bc9742a3a9ae4d52b319e0838fd21bf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27728
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Nicolas Capens [Thu, 21 Mar 2019 21:04:05 +0000 (17:04 -0400)]
Use a C array for temporary load results
Array<> emits GEP instructions on every access, which aren't necessary.
Note that these temporaries are required because the If/Else blocks
both write to them, while the destination intermediate object is an
rvalue which can only be initialized once to maintain SSA form.
Also EmitAccessChain was moved to match the declaration order.
Bug b/
128539387
Change-Id: I726fb0fd28b0a19a61e8759679e30bc699f3279d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27788
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Tue, 19 Mar 2019 20:22:35 +0000 (16:22 -0400)]
Implement atomic load/store
SIMD vector load and store are already atomic on x86 and ARM, and
Vulkan only supports atomic operations on "scalar 32-bit integer type".
Memory order semantics are handled in a follow-up change.
Bug b/
127472316
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.load
Test: dEQP-VK.spirv_assembly.instruction.compute.opatomic.store
Change-Id: I4481fe7b7aa792b63f516bd3cb1aab1d773bbcbd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27649
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Alexis Hetu [Fri, 22 Mar 2019 14:45:28 +0000 (10:45 -0400)]
Removed redundant flag
"-Wno-error=header-hygiene" was redundant with "-Wno-header-hygiene".
Removed it.
Change-Id: I5b75e8d42ef78c230cf064372f99db7950caf262
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27868
Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Mon, 18 Mar 2019 15:15:15 +0000 (15:15 +0000)]
Regres: Transition from out/ to build/
Change-Id: I9274f2141f14959ba614b57d45a637232baad5c8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27469
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Ben Clayton [Fri, 22 Mar 2019 09:25:32 +0000 (09:25 +0000)]
Regres: Include an example test for each of top N failures
Bug: b/
129056755
Change-Id: I01518b3cb802c45f2b3cc14e6e2c2f81416b4cd4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27782
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Nico Weber [Fri, 22 Mar 2019 12:16:16 +0000 (08:16 -0400)]
Merge upstream LLVM r356524.
Bug: chromium:944675
Change-Id: Icfe9d147fc6be936aac5a45f3bb6526022e5e898
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27848
Presubmit-Ready: Nico Weber <thakis@chromium.org>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nico Weber <thakis@chromium.org>
Ben Clayton [Thu, 21 Mar 2019 22:19:08 +0000 (22:19 +0000)]
PixelRoutine: Fix warning about missing override.
I have no idea why this has suddenly started firing.
Bug: b/
123933266
Change-Id: If94903e2b549bd628eb912569c1bb803bd576951
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27777
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 17:32:44 +0000 (17:32 +0000)]
SpirvShader: Minor changes for ASSERTs
sw::Intermediate would only clear the contents to zero in debug builds, but would always validate that these were nullptr in release (ASSERT still warns in release).
Given the cost nullifying this memory is negligable in comparison to the actual LLVM JIT, always clear.
Changed a bunch of ASSERT()s to ASSERT_MSG() where the additional information is useful.
Replaced a few remaining calls to assert() with ASSERT()
Bug: b/
127433389
Change-Id: Ifac89ca061bf7d61ff7d0de1792eeda18fad275c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27568
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <headlessclayton@gmail.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
SwiftShader Regression Bot [Fri, 22 Mar 2019 06:48:58 +0000 (06:48 +0000)]
Regres: Update test lists @
b55772e6
Change-Id: Ic3dcd942fe0f8d56536633434ce0b8ac6da8d066
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27778
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Ben Clayton [Thu, 21 Mar 2019 18:31:29 +0000 (18:31 +0000)]
VulkanUnitTests: Align the buffers to 0x100 for the compute tests
While not necessary for swiftshader, this is needed to compare against certain system vulkan drivers.
Bug: b/
128527271
Change-Id: I64c9e39659d565a0369c2989a324e4c09dbf7c02
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27773
Presubmit-Ready: Ben Clayton <headlessclayton@gmail.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 18:26:46 +0000 (18:26 +0000)]
VulkanUnitTests: Call vkDestroyDevice()
The system vulkan driver can get sulky if you don't free memory.
Bug: b/
123749916
Change-Id: I9bf2de63a788200c401b41fa3efdfb36f3c15245
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27772
Presubmit-Ready: Ben Clayton <headlessclayton@gmail.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Ben Clayton [Thu, 21 Mar 2019 18:22:28 +0000 (18:22 +0000)]
.gitignore: .vscode/ipch directory
It seems an update has started make these C++ extension PCH files show up in version control.
Change-Id: I9af5dbf7e74bf8fb7d9ef25e84cce28b7424dda8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27771
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <headlessclayton@gmail.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Thu, 21 Mar 2019 21:27:00 +0000 (17:27 -0400)]
Use Kokoro configs/scripts for SwiftShader under tests/kokoro/ directory
Bug b/
126742833
Change-Id: Ic07ebc74f342566905690a6059c742c4c2c47acd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27791
Tested-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Chris Forbes [Fri, 8 Mar 2019 20:43:00 +0000 (12:43 -0800)]
Remove remaining UBO & constants junk from DrawData
This isn't used. We have Ben's shiny new descriptor-based UBO system now
instead.
Change-Id: If971e6bce3ddfb149d33dc5c42294d7b75c31888
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26609
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Wed, 20 Mar 2019 01:38:44 +0000 (21:38 -0400)]
Rename Intermediate::emplace() to move()
Since we're essentially assigning from one rvalue to another, move()
seems to describe the intent better and even matches
register-to-register move instructions.
Bug b/
128539387
Change-Id: I409b3ede9578a100f25ea92e61f7492a38341ca4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26869
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Chris Forbes [Thu, 21 Mar 2019 18:23:28 +0000 (11:23 -0700)]
Ensure image strides are always suitable for the rasterizer
Bug: b/
129069789
Test: dEQP-VK.glsl.derivate.*
Change-Id: Iac1b5ed51dae0f6d8937b2162eb0a662d02b34ba
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27729
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Alexis Hetu [Mon, 18 Mar 2019 20:16:36 +0000 (16:16 -0400)]
vkCmdExecuteCommands implementation
Basic support for executing secondary command buffers, without
support for any inheritance features.
Bug b/
118619338
Change-Id: Ie3453018a45a722ecfa4f1acd20c95442fbb3d9b
Tests: dEQP-VK.memory.pipeline_barrier.host_write_transfer_src.*
Tests: dEQP-VK.api.command_buffers.allocate_single_secondary
Tests: dEQP-VK.api.command_buffers.allocate_many_secondary
Tests: dEQP-VK.api.command_buffers.trim_command_pool_secondary
Tests: dEQP-VK.api.command_buffers.record_single_secondary
Tests: dEQP-VK.api.command_buffers.record_many_secondary
Tests: dEQP-VK.api.command_buffers.submit_twice_secondary
Tests: dEQP-VK.api.command_buffers.record_one_time_submit_secondary
Tests: dEQP-VK.api.command_buffers.secondary_execute
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27493
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Chris Forbes [Mon, 18 Mar 2019 22:01:48 +0000 (15:01 -0700)]
Fix provoking vertex convention and remove configurability
- secondaryColor control only made sense in fixed-function
- Vulkan provoking vertex is always the first vertex
Bug: b/
125909515
Test: dEQP-VK.rasterization.flatshading.*
Change-Id: I9b6826e093076ee7ca5ef6deaf1b1fbd1c2f39e3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27509
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Chris Forbes [Thu, 21 Mar 2019 15:36:11 +0000 (08:36 -0700)]
Synchronize at end of renderpass
Heavy-handed implementation of implicit or explicit VkSubpassDependency
to VK_SUBPASS_EXTERNAL after a subpass.
Fixes various test flake.
Test: dEQP-VK.glsl.derivate.*
Change-Id: I9cb60828e6aff344e28dd7a8e1a867b5c8a11c22
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27708
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Alexis Hetu [Mon, 18 Mar 2019 18:24:38 +0000 (14:24 -0400)]
sw::Surface removed
There are no more dependencies on sw::Surface, it can now be removed.
Bug b/
126883332
Change-Id: I8d2deaa6eb78ffc1ce7be6614876a3c9a30da341
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27492
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Alexis Hetu [Mon, 18 Mar 2019 15:30:01 +0000 (11:30 -0400)]
sw::Surface references removed from sampling code
vk::Format was expanded to include more format related checks and the
sampler object now uses them. Whether or not the Sampler code ends up
actually being used is unsure, but the code has been updated to use
vk::Image instead of sw::Surface. This should be the last sw::Surface
reference in Vulkan code.
Bug b/
126883332
Change-Id: Ib1b4c3ce87d0fdad5ac7238b7e86211a499871a5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27490
Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Alexis Hetu [Fri, 15 Mar 2019 18:45:45 +0000 (14:45 -0400)]
Basic CommandBuffer::waitEvents implementation
Implemented waitEvents as a sync operation, like pipeline barriers,
since, as the Vulkan spec states:
"vkCmdWaitEvents is used with vkCmdSetEvent to define a memory
dependency between two sets of action commands, roughly in the
same way as pipeline barriers, but split into two commands such
that work between the two may execute unhindered."
Only the pEvents parameter is supported and currently doesn't support
pMemoryBarrier, pBufferMemoryBarriers or pImageMemoryBarriers.
Bug b/
118620868
Change-Id: I30ccc65c65dfc7d9a99e25ebb535061c618375cb
Tests: dEQP-VK.api.command_buffers.record_simul_use_primary
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27348
Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Tue, 19 Mar 2019 20:22:35 +0000 (16:22 -0400)]
Refactor variable type lookup
Previously the pointee type of OpVariable was determined starting from
the result ID. It just obtains the 'Object' which has the type collected
from the OpVariable instruction itself. So the object lookup can be
skipped by using the latter directly again.
Bug b/
129000021
Change-Id: I882d837c4cc1c7a8d0b19de38dc8ee19e622af33
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27651
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
SwiftShader Regression Bot [Thu, 21 Mar 2019 05:52:15 +0000 (05:52 +0000)]
Regres: Update test lists @
aff2dd06
Change-Id: I250bf1da0e6f1556af67f320b7cafabc4724f34f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27572
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Wed, 20 Mar 2019 21:50:24 +0000 (14:50 -0700)]
Add support for derivative instructions
- OpDPdx
- OpDPdy
- OpFwidth
- OpDPdxCoarse
- OpDPdyCoarse
- OpFwidthCoarse
- OpDPdxFine
- OpDPdyFine
- OpFwidthFine
We have flexibility in how we implement the OpDPdx, OpDPdy and OpFwidth
instructions; they can return either coarse or fine derivatives.
I have chosen to make them equivalent to the coarse derivatives since
those are slightly cheaper to compute.
Added a static assert to ensure we revisit these when considering other
vector widths.
Bug: b/
129002115
Test: dEQP-VK.glsl.derivate.*
Change-Id: I75224c1e77c1eefac4f219be5662836daa86a098
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27689
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Chris Forbes [Tue, 19 Mar 2019 23:48:03 +0000 (16:48 -0700)]
Vulkan: Plumb bound descriptor sets down to SpirvRoutine.
Choice of tests is slightly odd -- but there are a number of tests in
this group which *don't* use the derivative instructions (glslang is
smart enough to not emit them when the expression is known to be uniform).
Bug: b/
126330097
Test: dEQP-VK.glsl.derivate.*
Test: dEQP-VK.ubo.*
Change-Id: I8864149104f2ea9b62c75ceae59da4ff8adebc32
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26548
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Wed, 20 Mar 2019 19:15:46 +0000 (15:15 -0400)]
Fix MSVC build
Was wrongly assuming that if ..\deqp exists, the build directory must
be deqp\build.
Change-Id: I0e071565d9c41940efbcd4453de70f2994ad1be5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27652
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Chris Forbes [Sat, 9 Mar 2019 01:10:41 +0000 (17:10 -0800)]
Factor out vertex attribute binding from Draw*::play
I'm about to build some more on top of this; don't want to write it
multiple times.
Change-Id: I9ca84536f47b886e9f03edcaa6dc5dfe6e34091d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26688
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Tue, 19 Mar 2019 18:28:18 +0000 (14:28 -0400)]
Don't treat SIMD::Float preferentially
Intermediate::Scalar was defined as RValue<SIMD::Float>, even though it
can hold integers as well. Use abstract Reactor values instead which
don't have a statically defined type.
This change does not yet avoid bitcasting on access. The EmitLoad()
implementation still assumes values come in as float.
Bug b/
128539387
Change-Id: I18f449ebf68db7ddd81679d6d028911e6c02fc38
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26868
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
SwiftShader Regression Bot [Wed, 20 Mar 2019 07:56:55 +0000 (07:56 +0000)]
Regres: Update test lists @
f2564656
Change-Id: Ibfb2c1126253d98d15016b464e79e06f4d1bac8a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27570
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Tue, 19 Mar 2019 16:06:19 +0000 (09:06 -0700)]
Wire up BuiltInWorkgroupId to compute pipeline
Previously this was left uninitialized, with exciting results
when a shader used it for buffer indexing etc.
Bug: b/
126871859
Test: dEQP-VK.*push_constant*
Test: dEQP-VK.glsl.*
Test: dEQP-VK.spirv_assembly.*
Change-Id: I57fb9e22cbe57a87072b1039a7d799bedd28ae91
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27628
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Chris Forbes [Tue, 19 Mar 2019 16:06:19 +0000 (09:06 -0700)]
Carry decorations down type tree in WalkExplicitLayoutAccessChain
Bug: b/
128690261
Bug: b/
128872954
Test: dEQP-VK.*push_constant*
Test: dEQP-VK.glsl.*
Test: dEQP-VK.spirv_assembly.*
Change-Id: I0f8d103288777cd03347b32366ed5c5606e38b8d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27588
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Chris Forbes [Tue, 19 Mar 2019 01:51:55 +0000 (18:51 -0700)]
Add support for push constants
- Proper support for calculating offsets in explicit-layout storage
classes (push constant, uniform, and storage buffer) according to the
Offset, ArrayStride and MatrixStride decorations.
- Plumb a block of push constant data throughout the pipeline
- Implement push constant update commands
Bug: b/
128690261
Bug: b/
128872954
Test: dEQP-VK.*push_constant*
Test: dEQP-VK.glsl.*
Test: dEQP-VK.spirv_assembly.*
Change-Id: I7d5a66ac4aafd6b637b4693eb6ce96a327b4904e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27528
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Nicolas Capens [Tue, 19 Mar 2019 17:55:25 +0000 (13:55 -0400)]
Fix VulkanUnitTests on Visual Studio
Also copy the DLLs to build/
This makes it consistent with the CMake build.
Bug b/
116336664
Bug b/
29024574
Change-Id: I747a52383492c3ec5493f1a232cbbf5c98aec219
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27608
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Chris Forbes [Tue, 19 Mar 2019 02:31:16 +0000 (19:31 -0700)]
Add support for OpUndef
Treat OpUndef identically to OpConstantNull for now.
Change-Id: I721f2bf5e053d6a8d6f563272b1d44b6636a157c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27529
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Ben Clayton [Mon, 18 Mar 2019 15:13:48 +0000 (15:13 +0000)]
Regres: Categorize crashes caused by debug macros
List most common failures on the daily report.
Change-Id: Ia07f73601727f71e5f2abee7c40886e2a05209bb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27472
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Ben Clayton [Thu, 14 Mar 2019 10:08:17 +0000 (10:08 +0000)]
Regres: Fix priority boost for +2 code review.
Confusingly the "Code-Review" label uses 'Value' for -1 / +1, and 'Approved' for +2s.
Changes that were ready to land were not being prioritized over no-code review.
Change-Id: Ia31adcbbba70b2f52b9abc7299f4bafdcdb8fe48
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27170
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Ben Clayton [Thu, 14 Mar 2019 09:51:36 +0000 (09:51 +0000)]
Regres: Don't attempt to build failing changes forever.
If a test failed to build, an error was logged to stdout, but the error was not posted to the change. This meant the change would be picked up by regres again, and the process would repeat ad-infinitum.
Posting of the build error used to work, but was broken by
bfaf4e825b.
Change-Id: I1e59f0d2e5ee26eb002aa2c596dc5491e48a9c87
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27169
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Nicolas Capens [Mon, 18 Mar 2019 16:42:22 +0000 (12:42 -0400)]
Fix mipmap generation on undefined cube texture
Cube textures must be cube complete to generate mipmaps, but when the
base level is undefined the glGenerateMipmap command must be silently
ignored. This was previously leading to a null dereference.
Bug chromium:924022
Bug https://gitlab.khronos.org/opengl/API/issues/72
Change-Id: I5d6e8533118e554efa12045fc376126c7b00f263
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27491
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Nicolas Capens [Tue, 19 Mar 2019 05:52:40 +0000 (01:52 -0400)]
Use C++11 std::swap()
Bug b/
126126820
Change-Id: Iaf3991d58c64995018ba0d15773b65d463e03fad
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27549
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
SwiftShader Regression Bot [Tue, 19 Mar 2019 09:12:30 +0000 (09:12 +0000)]
Regres: Update test lists @
bbf5cf1e
Change-Id: I5aab5f50bad232227a7bf3af1dd40396c0f208a5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27449
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Chris Forbes [Wed, 6 Mar 2019 17:00:56 +0000 (09:00 -0800)]
Wire up sample mask correctly
Bug: b/
118386749
Change-Id: I4d6150907a0afea8eeff28334dae1e4af6309075
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26309
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Chris Forbes [Mon, 18 Mar 2019 18:41:56 +0000 (11:41 -0700)]
Tidy stencil state handling
Bug: b/
128715612
Change-Id: I1e9859d2cf001bfb341a49ad4f8fc9ef52c9fa5b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27508
Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>