OSDN Git Service

Revert "ugly, temporary, workaroung for a problem where a binder thread spins forever"
authorDave Burke <daveburke@google.com>
Sun, 7 Oct 2012 06:20:00 +0000 (23:20 -0700)
committerAndroid (Google) Code Review <android-gerrit@google.com>
Sun, 7 Oct 2012 06:20:00 +0000 (23:20 -0700)
This reverts commit 0845d0245e09548110cacb0f20e9934753388aab

Change-Id: I395037cb9427cd11f7de6bb78fbdfa917fc6263a

libs/binder/IPCThreadState.cpp

index 03c1082..6e83faa 100644 (file)
@@ -482,18 +482,6 @@ void IPCThreadState::joinThreadPool(bool isMain)
         if(result == TIMED_OUT && !isMain) {
             break;
         }
-
-        // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK
-        // FIXME: we sometimes get unexplained EINVAL which causes this
-        // thread to spin forever. TEMPORARILY allow it to exit.
-        // We should probably assert on eng builds
-        if(result == -EINVAL && !isMain) {
-            ALOGE("**** THREAD %p (PID %d) ERROR (%d) LEAVING THE THREAD POOL\n",
-                (void*)pthread_self(), getpid(), result);
-            break;
-        }
-        // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK
-
     } while (result != -ECONNREFUSED && result != -EBADF);
 
     LOG_THREADPOOL("**** THREAD %p (PID %d) IS LEAVING THE THREAD POOL err=%p\n",