OSDN Git Service

atrace: fix tracing on user builds
authorJamie Gennis <jgennis@google.com>
Wed, 27 Mar 2013 22:50:30 +0000 (15:50 -0700)
committerJamie Gennis <jgennis@google.com>
Wed, 27 Mar 2013 22:50:30 +0000 (15:50 -0700)
Change-Id: Idef15d514f0bd1e117362c6a06a2ea24314feb7f

cmds/atrace/atrace.cpp

index d85a1d7..b417383 100644 (file)
@@ -433,8 +433,10 @@ static bool setKernelTraceFuncs(const char* funcs)
 
     if (funcs == NULL || funcs[0] == '\0') {
         // Disable kernel function tracing.
-        ok &= writeStr(k_currentTracerPath, "nop");
-        if (fileExists(k_ftraceFilterPath)) {
+        if (fileIsWritable(k_currentTracerPath)) {
+            ok &= writeStr(k_currentTracerPath, "nop");
+        }
+        if (fileIsWritable(k_ftraceFilterPath)) {
             ok &= truncateFile(k_ftraceFilterPath);
         }
     } else {
@@ -761,11 +763,11 @@ int main(int argc, char **argv)
 
             case 'k':
                 g_kernelTraceFuncs = optarg;
-                break;
+            break;
 
             case 'n':
                 g_nohup = true;
-                break;
+            break;
 
             case 's':
                 g_initialSleepSecs = atoi(optarg);
@@ -796,7 +798,7 @@ int main(int argc, char **argv)
                     listSupportedCategories();
                     exit(0);
                 }
-                break;
+            break;
 
             default:
                 fprintf(stderr, "\n");