OSDN Git Service

Avoid dereferencing a pointer before checking pointer against NULL
authorXiang, Haihao <haihao.xiang@intel.com>
Fri, 26 Jan 2018 07:35:22 +0000 (15:35 +0800)
committerXiang, Haihao <haihao.xiang@intel.com>
Mon, 29 Jan 2018 01:07:38 +0000 (09:07 +0800)
It is possible a sequence parameter buffer is not provided by
application.

Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
src/i965_encoder.c

index 04f108e..d831541 100644 (file)
@@ -1024,12 +1024,11 @@ intel_encoder_check_mpeg2_parameter(VADriverContextP ctx,
 {
     struct i965_driver_data *i965 = i965_driver_data(ctx);
     VAEncPictureParameterBufferMPEG2 *pic_param = (VAEncPictureParameterBufferMPEG2 *)encode_state->pic_param_ext->buffer;
-    VAEncSequenceParameterBufferMPEG2 *seq_param = (VAEncSequenceParameterBufferMPEG2 *)encode_state->seq_param_ext->buffer;
+    VAEncSequenceParameterBufferMPEG2 *seq_param = NULL;
     struct object_surface *obj_surface;
     struct object_buffer *obj_buffer;
     int i = 0;
 
-    seq_param = NULL;
     if (encode_state->seq_param_ext &&
         encode_state->seq_param_ext->buffer)
         seq_param = (VAEncSequenceParameterBufferMPEG2 *)encode_state->seq_param_ext->buffer;