Bluetooth: hidp: replace kzalloc/copy_from_user by memdup_user

use memdup_user for rd_data import.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 1b7d605..cc25d0b 100644 (file)
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -736,14 +736,10 @@ static int hidp_setup_hid(struct hidp_session *session,
        struct hid_device *hid;
        int err;
 
-       session->rd_data = kzalloc(req->rd_size, GFP_KERNEL);
-       if (!session->rd_data)
-               return -ENOMEM;
+       session->rd_data = memdup_user(req->rd_data, req->rd_size);
+       if (IS_ERR(session->rd_data))
+               return PTR_ERR(session->rd_data);
 
-       if (copy_from_user(session->rd_data, req->rd_data, req->rd_size)) {
-               err = -EFAULT;
-               goto fault;
-       }
        session->rd_size = req->rd_size;
 
        hid = hid_allocate_device();